GraphicsMagick: 3 new changesets

changeset 9c5e7ef0314e in /hg/GraphicsMagick
details: http://hg.GraphicsMagick.org/hg/GraphicsMagick?cmd=changeset;node=9c5e7ef0314e
summary: Change from scan-build-12 to scan-build-13

changeset 4b0f27c1bcfa in /hg/GraphicsMagick
details: http://hg.GraphicsMagick.org/hg/GraphicsMagick?cmd=changeset;node=4b0f27c1bcfa
summary: Change from scan-build-12 to scan-build-13

changeset 9bc8392cd729 in /hg/GraphicsMagick
details: http://hg.GraphicsMagick.org/hg/GraphicsMagick?cmd=changeset;node=9bc8392cd729
summary: Block Coverity from seeing intentionally wasteful NULL assignments.

diffstat:

 Makefile.am          |  2 +-
 Makefile.in          |  2 +-
 coders/dcm.c         |  2 ++
 coders/mpeg.c        |  2 ++
 coders/xcf.c         |  2 ++
 magick/montage.c     |  2 ++
 magick/pixel_cache.c |  5 +++--
 magick/render.c      |  2 ++
 magick/xwindow.c     |  2 ++
 9 files changed, 17 insertions(+), 4 deletions(-)

diffs (125 lines):

diff -r 7828483c3316 -r 9bc8392cd729 Makefile.am
--- a/Makefile.am	Wed Aug 09 11:26:13 2023 -0500
+++ b/Makefile.am	Wed Aug 09 13:42:04 2023 -0500
@@ -489,7 +489,7 @@
 # The project should have been configured to use clang.
 #	-enable-checker security.insecureAPI.DeprecatedOrUnsafeBufferHandling
 scan-build:
-	scan-build-12 -k --html-title='GraphicsMagick' \
+	scan-build-13 -k --html-title='GraphicsMagick' \
 	-maxloop 1000 \
 	-disable-checker deadcode.DeadStores \
 	-enable-checker security.insecureAPI.bcmp \
diff -r 7828483c3316 -r 9bc8392cd729 Makefile.in
--- a/Makefile.in	Wed Aug 09 11:26:13 2023 -0500
+++ b/Makefile.in	Wed Aug 09 13:42:04 2023 -0500
@@ -11543,7 +11543,7 @@
 # The project should have been configured to use clang.
 #	-enable-checker security.insecureAPI.DeprecatedOrUnsafeBufferHandling
 scan-build:
-	scan-build-12 -k --html-title='GraphicsMagick' \
+	scan-build-13 -k --html-title='GraphicsMagick' \
 	-maxloop 1000 \
 	-disable-checker deadcode.DeadStores \
 	-enable-checker security.insecureAPI.bcmp \
diff -r 7828483c3316 -r 9bc8392cd729 coders/dcm.c
--- a/coders/dcm.c	Wed Aug 09 11:26:13 2023 -0500
+++ b/coders/dcm.c	Wed Aug 09 13:42:04 2023 -0500
@@ -7370,7 +7370,9 @@
           else if (next_image != (Image *) NULL)
             {
               DestroyImage(next_image);
+#if !defined(__COVERITY__) /* 384799 Unused value */
               next_image=(Image *) NULL;
+#endif /* if !defined(__COVERITY__) */
             }
         }
       (void) LiberateTemporaryFile(filename);
diff -r 7828483c3316 -r 9bc8392cd729 coders/mpeg.c
--- a/coders/mpeg.c	Wed Aug 09 11:26:13 2023 -0500
+++ b/coders/mpeg.c	Wed Aug 09 13:42:04 2023 -0500
@@ -300,7 +300,9 @@
           }
         }
       (void) fclose(parameter_file);
+#if !defined(__COVERITY__) /* 384796 Unused value */
       parameter_file=(FILE *) NULL;
+#endif /* if !defined(__COVERITY__) */
     }
   if (image_info->quality == DefaultCompressionQuality)
     (void) fprintf(file,"-\n");  /* default non intra quant matrix */
diff -r 7828483c3316 -r 9bc8392cd729 coders/xcf.c
--- a/coders/xcf.c	Wed Aug 09 11:26:13 2023 -0500
+++ b/coders/xcf.c	Wed Aug 09 13:42:04 2023 -0500
@@ -926,7 +926,9 @@
 #endif
         }
       DestroyImage(tile_image);
+#if !defined(__COVERITY__) /* 384797 Unused value */
       tile_image = (Image *) NULL;
+#endif /* if !defined(__COVERITY__) */
 
       /* adjust tile position */
       destLeft++;
diff -r 7828483c3316 -r 9bc8392cd729 magick/montage.c
--- a/magick/montage.c	Wed Aug 09 11:26:13 2023 -0500
+++ b/magick/montage.c	Wed Aug 09 13:42:04 2023 -0500
@@ -773,7 +773,9 @@
           break;
         }
       DestroyImage(image);
+#if !defined(__COVERITY__) /* 384804 Unused value */
       image=(Image *) NULL;
+#endif /* if !defined(__COVERITY__) */
       tiles++;
     }
     if ((i+1) < (long) images_per_page)
diff -r 7828483c3316 -r 9bc8392cd729 magick/pixel_cache.c
--- a/magick/pixel_cache.c	Wed Aug 09 11:26:13 2023 -0500
+++ b/magick/pixel_cache.c	Wed Aug 09 13:42:04 2023 -0500
@@ -515,8 +515,7 @@
     MagickFatalError3(ResourceLimitFatalError,MemoryAllocationFailed,
                       UnableToAllocateCacheView);
   view_set->nviews=nviews;
-  view_set->views=MagickAllocateMemory(ViewInfo *,
-                                       view_set->nviews*sizeof(ViewInfo *));
+  view_set->views=MagickAllocateArray(ViewInfo *,view_set->nviews,sizeof(ViewInfo *));
   if (view_set->views == (ViewInfo *) NULL)
     {
       ThrowException(exception,CacheError,UnableToAllocateCacheView,
@@ -4586,7 +4585,9 @@
     if (destroy_cache)
       {
         DestroyCacheInfo(cache_info);
+#if !defined(__COVERITY__) /* 384801 Unused value */
         cache_info=(CacheInfo *) NULL;
+#endif /* if !defined(__COVERITY__) */
       }
 
     if (status != MagickFail)
diff -r 7828483c3316 -r 9bc8392cd729 magick/render.c
--- a/magick/render.c	Wed Aug 09 11:26:13 2023 -0500
+++ b/magick/render.c	Wed Aug 09 13:42:04 2023 -0500
@@ -687,7 +687,9 @@
             polygon_info->edges[edge].bounds.y1=points[0].y;
             polygon_info->edges[edge].bounds.y2=points[n-1].y;
             points=(PointInfo *) NULL;
+#if !defined(__COVERITY__) /* 384800 Unused value */
             ghostline=MagickFalse;
+#endif /* if !defined(__COVERITY__) */
             edge++;
             polygon_info->number_edges=edge;
           }
diff -r 7828483c3316 -r 9bc8392cd729 magick/xwindow.c
--- a/magick/xwindow.c	Wed Aug 09 11:26:13 2023 -0500
+++ b/magick/xwindow.c	Wed Aug 09 13:42:04 2023 -0500
@@ -4535,7 +4535,9 @@
           }
         }
         XDestroyImage(ximage);
+#if !defined(__COVERITY__) /* 384805 Unused value */
         ximage=(XImage *) NULL;
+#endif /* if !defined(__COVERITY__) */
 
         /*
           Evaluate image depth.