GraphicsMagick: ResizeImage() Restore previous vertical/horizont...

GraphicsMagick Commits <[email protected]> Sat, 02 Sep 2023 09:51:04 -0500
Newsgroups gmane.comp.video.graphicsmagick.cvs
Message-ID <mailman.13826.1693666277.8047.graphicsmagick-commit@lists.sourceforge.net>
changeset f6375160b0de in /hg/GraphicsMagick
details: http://hg.GraphicsMagick.org/hg/GraphicsMagick?cmd=changeset;node=f6375160b0de
summary: ResizeImage() Restore previous vertical/horizontal filter order decision logic

diffstat:

 ChangeLog                              |  10 ++++++++++
 VisualMagick/installer/inc/version.isx |   4 ++--
 magick/resize.c                        |   2 +-
 magick/version.h                       |   4 ++--
 www/Changelog.html                     |  14 +++++++++++++-
 5 files changed, 28 insertions(+), 6 deletions(-)

diffs (85 lines):

diff -r 2e76d4fb434c -r f6375160b0de ChangeLog
--- a/ChangeLog	Fri Sep 01 08:29:42 2023 -0500
+++ b/ChangeLog	Sat Sep 02 09:50:59 2023 -0500
@@ -1,3 +1,13 @@
+2023-09-02  Bob Friesenhahn  <[email protected]>
+
+	* magick/resize.c (ResizeImage): Restore vertical/horizontal
+	filter order decision logic which was in place before the 1.3.41
+	release since it may result in tiny changes to low order bits in
+	16-bit/sample images, which may be concerning to some.  Resolves
+	SourceForge issue #723 "montage result differ between 1.3.40 and
+	1.3.41". The provided test-case showed that the filter filter
+	order changed from "Vertical/Horizontal" to "Horizontal/Vertical".
+
 2023-09-01  Bob Friesenhahn  <[email protected]>
 
 	* magick/command.c (MogrifyImage): Use MaxRGBDouble double
diff -r 2e76d4fb434c -r f6375160b0de VisualMagick/installer/inc/version.isx
--- a/VisualMagick/installer/inc/version.isx	Fri Sep 01 08:29:42 2023 -0500
+++ b/VisualMagick/installer/inc/version.isx	Sat Sep 02 09:50:59 2023 -0500
@@ -10,5 +10,5 @@
 
 #define public MagickPackageName "GraphicsMagick"
 #define public MagickPackageVersion "1.4"
-#define public MagickPackageVersionAddendum ".020230901"
-#define public MagickPackageReleaseDate "snapshot-20230901"
+#define public MagickPackageVersionAddendum ".020230902"
+#define public MagickPackageReleaseDate "snapshot-20230902"
diff -r 2e76d4fb434c -r f6375160b0de magick/resize.c
--- a/magick/resize.c	Fri Sep 01 08:29:42 2023 -0500
+++ b/magick/resize.c	Sat Sep 02 09:50:59 2023 -0500
@@ -1460,7 +1460,7 @@
   if (resize_image == (Image *) NULL)
     return ((Image *) NULL);
 
-  order=(((double) columns*((size_t) image->rows+rows)) >=
+  order=(((double) columns*((size_t) image->rows+rows)) >
          ((double) rows*((size_t) image->columns+columns)));
   if (order)
     source_image=CloneImage(resize_image,columns,image->rows,True,exception);
diff -r 2e76d4fb434c -r f6375160b0de magick/version.h
--- a/magick/version.h	Fri Sep 01 08:29:42 2023 -0500
+++ b/magick/version.h	Sat Sep 02 09:50:59 2023 -0500
@@ -38,8 +38,8 @@
 #define MagickLibVersion  0x272403
 #define MagickLibVersionText  "1.4"
 #define MagickLibVersionNumber 27,24,3
-#define MagickChangeDate   "20230901"
-#define MagickReleaseDate  "snapshot-20230901"
+#define MagickChangeDate   "20230902"
+#define MagickReleaseDate  "snapshot-20230902"
 
 /*
   The MagickLibInterfaceNewest and MagickLibInterfaceOldest defines
diff -r 2e76d4fb434c -r f6375160b0de www/Changelog.html
--- a/www/Changelog.html	Fri Sep 01 08:29:42 2023 -0500
+++ b/www/Changelog.html	Sat Sep 02 09:50:59 2023 -0500
@@ -37,6 +37,18 @@
 </div>
 
 <div class="document">
+<p>2023-09-02  Bob Friesenhahn  &lt;<a class="reference external" href="mailto:bfriesen&#37;&#52;&#48;simple&#46;dallas&#46;tx&#46;us">bfriesen<span>&#64;</span>simple<span>&#46;</span>dallas<span>&#46;</span>tx<span>&#46;</span>us</a>&gt;</p>
+<blockquote>
+<ul class="simple">
+<li><p>magick/resize.c (ResizeImage): Restore vertical/horizontal
+filter order decision logic which was in place before the 1.3.41
+release since it may result in tiny changes to low order bits in
+16-bit/sample images, which may be concerning to some.  Resolves
+SourceForge issue #723 &quot;montage result differ between 1.3.40 and
+1.3.41&quot;. The provided test-case showed that the filter filter
+order changed from &quot;Vertical/Horizontal&quot; to &quot;Horizontal/Vertical&quot;.</p></li>
+</ul>
+</blockquote>
 <p>2023-09-01  Bob Friesenhahn  &lt;<a class="reference external" href="mailto:bfriesen&#37;&#52;&#48;simple&#46;dallas&#46;tx&#46;us">bfriesen<span>&#64;</span>simple<span>&#46;</span>dallas<span>&#46;</span>tx<span>&#46;</span>us</a>&gt;</p>
 <blockquote>
 <ul class="simple">
@@ -72,7 +84,7 @@
 </dd>
 </dl>
 <div class="system-message">
-<p class="system-message-title">System Message: WARNING/2 (<span class="docutils literal">&lt;string&gt;</span>, line 26)</p>
+<p class="system-message-title">System Message: WARNING/2 (<span class="docutils literal">&lt;string&gt;</span>, line 36)</p>
 <p>Definition list ends without a blank line; unexpected unindent.</p>
 </div>
 <p>The opacity channel handling is even more complex.</p>