GraphicsMagick: WriteTIFFImage(): Call TIFFFlush() to detect any...

GraphicsMagick Commits <[email protected]> Tue, 14 Nov 2023 08:11:53 -0600
Newsgroups gmane.comp.video.graphicsmagick.cvs
Message-ID <mailman.2303.1699971129.1408.graphicsmagick-commit@lists.sourceforge.net>
changeset 3d1ba3ed2aca in /hg/GraphicsMagick
details: http://hg.GraphicsMagick.org/hg/GraphicsMagick?cmd=changeset;node=3d1ba3ed2aca
summary: WriteTIFFImage(): Call TIFFFlush() to detect any errors which might otherwise be lost by TIFFClose()

diffstat:

 ChangeLog                              |  6 ++++++
 VisualMagick/installer/inc/version.isx |  4 ++--
 coders/tiff.c                          |  4 ++--
 magick/version.h                       |  4 ++--
 www/Changelog.html                     |  8 ++++++++
 5 files changed, 20 insertions(+), 6 deletions(-)

diffs (79 lines):

diff -r afe749bebed9 -r 3d1ba3ed2aca ChangeLog
--- a/ChangeLog	Mon Nov 13 10:09:05 2023 -0600
+++ b/ChangeLog	Tue Nov 14 08:11:47 2023 -0600
@@ -1,3 +1,9 @@
+2023-11-14  Bob Friesenhahn  <[email protected]>
+
+	* coders/tiff.c (WriteTIFFImage): Call TIFFFlush() to detect any
+	errors which might otherwise be lost by TIFFClose().  Restore
+	broken file deletion code.
+
 2023-11-13  Bob Friesenhahn  <[email protected]>
 
 	* tests/rwfile.c, tests/rwblob.c: Print reproducible test
diff -r afe749bebed9 -r 3d1ba3ed2aca VisualMagick/installer/inc/version.isx
--- a/VisualMagick/installer/inc/version.isx	Mon Nov 13 10:09:05 2023 -0600
+++ b/VisualMagick/installer/inc/version.isx	Tue Nov 14 08:11:47 2023 -0600
@@ -10,5 +10,5 @@
 
 #define public MagickPackageName "GraphicsMagick"
 #define public MagickPackageVersion "1.4"
-#define public MagickPackageVersionAddendum ".020231113"
-#define public MagickPackageReleaseDate "snapshot-20231113"
+#define public MagickPackageVersionAddendum ".020231114"
+#define public MagickPackageReleaseDate "snapshot-20231114"
diff -r afe749bebed9 -r 3d1ba3ed2aca coders/tiff.c
--- a/coders/tiff.c	Mon Nov 13 10:09:05 2023 -0600
+++ b/coders/tiff.c	Tue Nov 14 08:11:47 2023 -0600
@@ -6484,9 +6484,10 @@
     } while (image_info->adjoin);
   while (image->previous != (Image *) NULL)
     image=image->previous;
+  if (TIFFFlush(tiff) != 1) /* Flush pending writes, check status */
+    status=MagickFail;
   TIFFClose(tiff); /* Should implicity invoke CloseBlob(image) */
 
-#if 0
   if (status == MagickFail)
     {
       /*
@@ -6497,7 +6498,6 @@
         (void) LogMagickEvent(CoderEvent,GetMagickModule(),
                               "Removed broken output file \"%s\"",filename);
     }
-#endif
 
   return(status);
 }
diff -r afe749bebed9 -r 3d1ba3ed2aca magick/version.h
--- a/magick/version.h	Mon Nov 13 10:09:05 2023 -0600
+++ b/magick/version.h	Tue Nov 14 08:11:47 2023 -0600
@@ -38,8 +38,8 @@
 #define MagickLibVersion  0x272404
 #define MagickLibVersionText  "1.4"
 #define MagickLibVersionNumber 27,24,4
-#define MagickChangeDate   "20231113"
-#define MagickReleaseDate  "snapshot-20231113"
+#define MagickChangeDate   "20231114"
+#define MagickReleaseDate  "snapshot-20231114"
 
 /*
   The MagickLibInterfaceNewest and MagickLibInterfaceOldest defines
diff -r afe749bebed9 -r 3d1ba3ed2aca www/Changelog.html
--- a/www/Changelog.html	Mon Nov 13 10:09:05 2023 -0600
+++ b/www/Changelog.html	Tue Nov 14 08:11:47 2023 -0600
@@ -37,6 +37,14 @@
 </div>
 
 <div class="document">
+<p>2023-11-14  Bob Friesenhahn  &lt;<a class="reference external" href="mailto:bfriesen&#37;&#52;&#48;simple&#46;dallas&#46;tx&#46;us">bfriesen<span>&#64;</span>simple<span>&#46;</span>dallas<span>&#46;</span>tx<span>&#46;</span>us</a>&gt;</p>
+<blockquote>
+<ul class="simple">
+<li><p>coders/tiff.c (WriteTIFFImage): Call TIFFFlush() to detect any
+errors which might otherwise be lost by TIFFClose().  Restore
+broken file deletion code.</p></li>
+</ul>
+</blockquote>
 <p>2023-11-13  Bob Friesenhahn  &lt;<a class="reference external" href="mailto:bfriesen&#37;&#52;&#48;simple&#46;dallas&#46;tx&#46;us">bfriesen<span>&#64;</span>simple<span>&#46;</span>dallas<span>&#46;</span>tx<span>&#46;</span>us</a>&gt;</p>
 <blockquote>
 <ul class="simple">