GraphicsMagick: AddIFDExifFields(): Avoid signed/unsigned compar...
GraphicsMagick Commits <[email protected]> Sat, 27 Jan 2024 10:32:48 -0600
| Newsgroups | gmane.comp.video.graphicsmagick.cvs |
|---|---|
| Message-ID | <mailman.2094.1706373186.1744.graphicsmagick-commit@lists.sourceforge.net> |
changeset f2d6ca2a19dc in /hg/GraphicsMagick details: http://hg.GraphicsMagick.org/hg/GraphicsMagick?cmd=changeset;node=f2d6ca2a19dc summary: AddIFDExifFields(): Avoid signed/unsigned comparison warnings. diffstat: ChangeLog | 6 +++++- VisualMagick/installer/inc/version.isx | 4 ++-- coders/tiff.c | 4 ++-- magick/version.h | 4 ++-- www/Changelog.html | 22 +++++++++++++++++++++- 5 files changed, 32 insertions(+), 8 deletions(-) diffs (100 lines): diff -r b7d6c142161e -r f2d6ca2a19dc ChangeLog --- a/ChangeLog Sat Jan 27 16:06:20 2024 +0100 +++ b/ChangeLog Sat Jan 27 10:32:45 2024 -0600 @@ -1,6 +1,10 @@ +2024-01-27 Bob Friesenhahn <[email protected]> + + * coders/tiff.c (AddIFDExifFields): Avoid signed/unsigned comparison warnings. + 2024-01-27 Fojtik Jaroslav <[email protected]> - coders/tiff.c: EXIF GPS IFD tags are copyed now. + coders/tiff.c: EXIF GPS IFD tags are copied now. 2024-01-26 Fojtik Jaroslav <[email protected]> diff -r b7d6c142161e -r f2d6ca2a19dc VisualMagick/installer/inc/version.isx --- a/VisualMagick/installer/inc/version.isx Sat Jan 27 16:06:20 2024 +0100 +++ b/VisualMagick/installer/inc/version.isx Sat Jan 27 10:32:45 2024 -0600 @@ -10,5 +10,5 @@ #define public MagickPackageName "GraphicsMagick" #define public MagickPackageVersion "1.4" -#define public MagickPackageVersionAddendum ".020240125" -#define public MagickPackageReleaseDate "snapshot-20240125" +#define public MagickPackageVersionAddendum ".020240127" +#define public MagickPackageReleaseDate "snapshot-20240127" diff -r b7d6c142161e -r f2d6ca2a19dc coders/tiff.c --- a/coders/tiff.c Sat Jan 27 16:06:20 2024 +0100 +++ b/coders/tiff.c Sat Jan 27 10:32:45 2024 -0600 @@ -4602,7 +4602,7 @@ if(FDT!=Field) break; /* Incompatible array type, might be converted in future. */ if(WriteCount!=TIFF_VARIABLE && WriteCount!=TIFF_VARIABLE2) { - if(Long2<WriteCount) break; /* Too small amount of mandatory items. */ + if((WriteCount<=0)||(Long2<(magick_uint32_t)WriteCount)) break; /* Too small amount of mandatory items. */ if(Long2<=4) { if(TIFFSetField(tiff, Tag, IFD_data+8)) /* Argument 3 uint8_t[4]. */ @@ -4655,7 +4655,7 @@ if(Value+8*WriteCount>=profile_length-1) break; ArrayD = MagickAllocateResourceLimitedMemory(double *, sizeof(double)*WriteCount); if(ArrayD==NULL) break; - for(i=0; i<WriteCount; i++) + for(i=0; i<(magick_uint32_t)WriteCount; i++) { const magick_uint32_t val = LD_UINT32(profile_data+Value+4+8*i); ArrayD[i] = (val==0) ? 0.0 : (LD_UINT32(profile_data+Value+8*i) / (double)val); diff -r b7d6c142161e -r f2d6ca2a19dc magick/version.h --- a/magick/version.h Sat Jan 27 16:06:20 2024 +0100 +++ b/magick/version.h Sat Jan 27 10:32:45 2024 -0600 @@ -38,8 +38,8 @@ #define MagickLibVersion 0x272404 #define MagickLibVersionText "1.4" #define MagickLibVersionNumber 27,24,4 -#define MagickChangeDate "20240125" -#define MagickReleaseDate "snapshot-20240125" +#define MagickChangeDate "20240127" +#define MagickReleaseDate "snapshot-20240127" /* The MagickLibInterfaceNewest and MagickLibInterfaceOldest defines diff -r b7d6c142161e -r f2d6ca2a19dc www/Changelog.html --- a/www/Changelog.html Sat Jan 27 16:06:20 2024 +0100 +++ b/www/Changelog.html Sat Jan 27 10:32:45 2024 -0600 @@ -37,6 +37,26 @@ </div> <div class="document"> +<p>2024-01-27 Bob Friesenhahn <<a class="reference external" href="mailto:bfriesen%40simple.dallas.tx.us">bfriesen<span>@</span>simple<span>.</span>dallas<span>.</span>tx<span>.</span>us</a>></p> +<blockquote> +<ul class="simple"> +<li><p>coders/tiff.c (AddIFDExifFields): Avoid signed/unsigned comparison warnings.</p></li> +</ul> +</blockquote> +<p>2024-01-27 Fojtik Jaroslav <<a class="reference external" href="mailto:JaFojtik%40yandex.com">JaFojtik<span>@</span>yandex<span>.</span>com</a>></p> +<blockquote> +<p>coders/tiff.c: EXIF GPS IFD tags are copied now.</p> +</blockquote> +<p>2024-01-26 Fojtik Jaroslav <<a class="reference external" href="mailto:JaFojtik%40yandex.com">JaFojtik<span>@</span>yandex<span>.</span>com</a>></p> +<blockquote> +<p>tiff/libtiff/tif_dir.c: Apply Su Laus leak fix from: +<a class="reference external" href="https://gitlab.com/libtiff/libtiff/-/commit/376916d25f39bab69a3ed16963fd3f186870942c">https://gitlab.com/libtiff/libtiff/-/commit/376916d25f39bab69a3ed16963fd3f186870942c</a></p> +</blockquote> +<p>2024-01-26 Fojtik Jaroslav <<a class="reference external" href="mailto:JaFojtik%40yandex.com">JaFojtik<span>@</span>yandex<span>.</span>com</a>></p> +<blockquote> +<p>coders/tiff.c: Refactor types to magick_uint16_t and +magick_uint32_t.</p> +</blockquote> <p>2024-01-25 Bob Friesenhahn <<a class="reference external" href="mailto:bfriesen%40simple.dallas.tx.us">bfriesen<span>@</span>simple<span>.</span>dallas<span>.</span>tx<span>.</span>us</a>></p> <blockquote> <ul class="simple"> @@ -64,7 +84,7 @@ </ul> </blockquote> <div class="system-message"> -<p class="system-message-title">System Message: WARNING/2 (<span class="docutils literal"><string></span>, line 20)</p> +<p class="system-message-title">System Message: WARNING/2 (<span class="docutils literal"><string></span>, line 38)</p> <p>Block quote ends without a blank line; unexpected unindent.</p> </div> <p>2024-01-23 Fojtik Jaroslav <<a class="reference external" href="mailto:JaFojtik%40yandex.com">JaFojtik<span>@</span>yandex<span>.</span>com</a>></p>