GraphicsMagick: wand/magick_wand.c: Assure that functions using ...

GraphicsMagick Commits <[email protected]> Fri, 15 Mar 2024 08:50:44 -0500
Newsgroups gmane.comp.video.graphicsmagick.cvs
Message-ID <mailman.2893.1710510662.7900.graphicsmagick-commit@lists.sourceforge.net>
changeset ee005758e1a6 in /hg/GraphicsMagick
details: http://hg.GraphicsMagick.org/hg/GraphicsMagick?cmd=changeset;node=ee005758e1a6
summary: wand/magick_wand.c: Assure that functions using AppendImageToList() update wand->images to point to the beginning of the list.

diffstat:

 ChangeLog                              |  10 ++++++++++
 VisualMagick/installer/inc/version.isx |   4 ++--
 magick/version.h                       |   4 ++--
 wand/magick_wand.c                     |   6 +++++-
 www/ChangeLog.html                     |  12 ++++++++++++
 5 files changed, 31 insertions(+), 5 deletions(-)

diffs (105 lines):

diff -r c98f714d4e64 -r ee005758e1a6 ChangeLog
--- a/ChangeLog	Sat Mar 09 13:47:58 2024 -0600
+++ b/ChangeLog	Fri Mar 15 08:49:55 2024 -0500
@@ -1,3 +1,13 @@
+2024-03-15  Bob Friesenhahn  <[email protected]>
+
+	* wand/magick_wand.c (MagickPingImage, MagickReadImage)
+	(MagickReadImageBlob, MagickReadImageFile): AppendImageToList()
+	now leaves the image pointer pointing to the end of the list.  The
+	Wand implementation expects that wand->images points to the
+	begining of the list.  Update wand->images to point to the
+	beginning of the list.  Resolves SourceForge issue #735
+	"[MagickWand] Potential regression when creating GIFs".
+
 2024-03-09  Bob Friesenhahn  <[email protected]>
 
 	* utilities/Makefile.am: Give up on the attempt to selectively
diff -r c98f714d4e64 -r ee005758e1a6 VisualMagick/installer/inc/version.isx
--- a/VisualMagick/installer/inc/version.isx	Sat Mar 09 13:47:58 2024 -0600
+++ b/VisualMagick/installer/inc/version.isx	Fri Mar 15 08:49:55 2024 -0500
@@ -10,5 +10,5 @@
 
 #define public MagickPackageName "GraphicsMagick"
 #define public MagickPackageVersion "1.4"
-#define public MagickPackageVersionAddendum ".020240309"
-#define public MagickPackageReleaseDate "snapshot-20240309"
+#define public MagickPackageVersionAddendum ".020240315"
+#define public MagickPackageReleaseDate "snapshot-20240315"
diff -r c98f714d4e64 -r ee005758e1a6 magick/version.h
--- a/magick/version.h	Sat Mar 09 13:47:58 2024 -0600
+++ b/magick/version.h	Fri Mar 15 08:49:55 2024 -0500
@@ -38,8 +38,8 @@
 #define MagickLibVersion  0x272404
 #define MagickLibVersionText  "1.4"
 #define MagickLibVersionNumber 27,24,4
-#define MagickChangeDate   "20240309"
-#define MagickReleaseDate  "snapshot-20240309"
+#define MagickChangeDate   "20240315"
+#define MagickReleaseDate  "snapshot-20240315"
 
 /*
   The MagickLibInterfaceNewest and MagickLibInterfaceOldest defines
diff -r c98f714d4e64 -r ee005758e1a6 wand/magick_wand.c
--- a/wand/magick_wand.c	Sat Mar 09 13:47:58 2024 -0600
+++ b/wand/magick_wand.c	Fri Mar 15 08:49:55 2024 -0500
@@ -1,4 +1,4 @@
-/* Copyright (C) 2003-2019 GraphicsMagick Group */
+/* Copyright (C) 2003-2024 GraphicsMagick Group */
 /*
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 %                                                                             %
@@ -6496,6 +6496,7 @@
     return(False);
   AppendImageToList(&wand->images,images);
   wand->image=GetLastImageInList(wand->images);
+  wand->images=GetFirstImageInList(wand->image);
   return(True);
 }
 
@@ -7135,6 +7136,7 @@
     return(False);
   AppendImageToList(&wand->images,images);
   wand->image=GetLastImageInList(wand->images);
+  wand->images=GetFirstImageInList(wand->image);
   return(True);
 }
 
@@ -7178,6 +7180,7 @@
     return(False);
   AppendImageToList(&wand->images,images);
   wand->image=GetLastImageInList(wand->images);
+  wand->images=GetFirstImageInList(wand->image);
   return(True);
 }
 
@@ -7224,6 +7227,7 @@
     return(False);
   AppendImageToList(&wand->images,images);
   wand->image=GetLastImageInList(wand->images);
+  wand->images=GetFirstImageInList(wand->image);
   return(True);
 }
 
diff -r c98f714d4e64 -r ee005758e1a6 www/ChangeLog.html
--- a/www/ChangeLog.html	Sat Mar 09 13:47:58 2024 -0600
+++ b/www/ChangeLog.html	Fri Mar 15 08:49:55 2024 -0500
@@ -38,6 +38,18 @@
 
 <div class="document" id="graphicsmagick-changelog">
 <h1 class="title">GraphicsMagick ChangeLog</h1>
+<p>2024-03-15  Bob Friesenhahn  &lt;<a class="reference external" href="mailto:bfriesen&#37;&#52;&#48;simple&#46;dallas&#46;tx&#46;us">bfriesen<span>&#64;</span>simple<span>&#46;</span>dallas<span>&#46;</span>tx<span>&#46;</span>us</a>&gt;</p>
+<blockquote>
+<ul class="simple">
+<li><p>wand/magick_wand.c (MagickPingImage, MagickReadImage)
+(MagickReadImageBlob, MagickReadImageFile): AppendImageToList()
+now leaves the image pointer pointing to the end of the list.  The
+Wand implementation expects that wand-&gt;images points to the
+begining of the list.  Update wand-&gt;images to point to the
+beginning of the list.  Resolves SourceForge issue #735
+&quot;[MagickWand] Potential regression when creating GIFs&quot;.</p></li>
+</ul>
+</blockquote>
 <p>2024-03-09  Bob Friesenhahn  &lt;<a class="reference external" href="mailto:bfriesen&#37;&#52;&#48;simple&#46;dallas&#46;tx&#46;us">bfriesen<span>&#64;</span>simple<span>&#46;</span>dallas<span>&#46;</span>tx<span>&#46;</span>us</a>&gt;</p>
 <blockquote>
 <ul class="simple">