GraphicsMagick: 3 new changesets

GraphicsMagick Commits <[email protected]> Wed, 15 May 2024 18:25:30 -0500
Newsgroups gmane.comp.video.graphicsmagick.cvs
Message-ID <mailman.2571.1715815542.8076.graphicsmagick-commit@lists.sourceforge.net>
changeset c558f356540b in /hg/GraphicsMagick
details: http://hg.GraphicsMagick.org/hg/GraphicsMagick?cmd=changeset;node=c558f356540b
summary: coders/tiff.c: TIFFTAG_INKNAMES should have a first optional parameter of the type uint16_t.

changeset 02608bf203dd in /hg/GraphicsMagick
details: http://hg.GraphicsMagick.org/hg/GraphicsMagick?cmd=changeset;node=02608bf203dd
summary: merge

changeset 320af918e5b3 in /hg/GraphicsMagick
details: http://hg.GraphicsMagick.org/hg/GraphicsMagick?cmd=changeset;node=320af918e5b3
summary: Update generated files

diffstat:

 ChangeLog                              |  10 ++++++++++
 VisualMagick/installer/inc/version.isx |   4 ++--
 coders/tiff.c                          |   6 +++++-
 magick/utility.c                       |   6 ++++++
 magick/version.h                       |   4 ++--
 www/ChangeLog.html                     |  16 ++++++++++++++++
 6 files changed, 41 insertions(+), 5 deletions(-)

diffs (100 lines):

diff -r 5488b9864182 -r 320af918e5b3 ChangeLog
--- a/ChangeLog	Wed May 15 16:09:31 2024 -0500
+++ b/ChangeLog	Wed May 15 18:24:58 2024 -0500
@@ -1,3 +1,13 @@
+2024-05-16  Fojtik Jaroslav  <[email protected]>
+	* coders/tiff.c: TIFFTAG_INKNAMES should have a first parameter of 
+	the type uint16_t.
+
+2024-05-15  Bob Friesenhahn  <[email protected]>
+
+	* magick/utility.c (ExpandFilenames): Address Coverity 425853:
+	"Resource leaks (RESOURCE_LEAK) Variable "filelist" going out of
+	scope leaks the storage it points to.".
+
 2024-05-15  Fojtik Jaroslav  <[email protected]>
 
 	* coders/tiff.c: Fixed problem with overflowing IFD.
diff -r 5488b9864182 -r 320af918e5b3 VisualMagick/installer/inc/version.isx
--- a/VisualMagick/installer/inc/version.isx	Wed May 15 16:09:31 2024 -0500
+++ b/VisualMagick/installer/inc/version.isx	Wed May 15 18:24:58 2024 -0500
@@ -10,5 +10,5 @@
 
 #define public MagickPackageName "GraphicsMagick"
 #define public MagickPackageVersion "1.4"
-#define public MagickPackageVersionAddendum ".020240515"
-#define public MagickPackageReleaseDate "snapshot-20240515"
+#define public MagickPackageVersionAddendum ".020240516"
+#define public MagickPackageReleaseDate "snapshot-20240516"
diff -r 5488b9864182 -r 320af918e5b3 coders/tiff.c
--- a/coders/tiff.c	Wed May 15 16:09:31 2024 -0500
+++ b/coders/tiff.c	Wed May 15 18:24:58 2024 -0500
@@ -4467,7 +4467,11 @@
 magick_uint32_t i = StrSize;
 
   if(Tag==TIFFTAG_INKNAMES)		/* Variant of call is tag dependent, too bad. */
-        return TIFFSetField(tiff, Tag, StrSize, String);
+  {
+    if(StrSize>0xFFFF) return 0;
+    /* TIFFTAG_INKNAMES needs only uint16_t https://libtiff.gitlab.io/libtiff/functions/TIFFSetField.html#c.TIFFSetField */
+    return TIFFSetField(tiff, Tag, (magick_uint16_t)StrSize, String);
+  }
 
 	/* Look for zero terminator. */
   while(i>0)
diff -r 5488b9864182 -r 320af918e5b3 magick/utility.c
--- a/magick/utility.c	Wed May 15 16:09:31 2024 -0500
+++ b/magick/utility.c	Wed May 15 18:24:58 2024 -0500
@@ -1128,6 +1128,12 @@
              for (j=0 ; j < count; j++)
                MagickFreeMemory(vector[j]);
              MagickFreeMemory(vector);
+             if (filelist != (char **) NULL)
+               {
+                 for (j=0; j < number_files; j++)
+                   MagickFreeMemory(filelist[j]);
+                 MagickFreeMemory(filelist);
+               }
              return(MagickFail);
            }
          vector=new_vector;
diff -r 5488b9864182 -r 320af918e5b3 magick/version.h
--- a/magick/version.h	Wed May 15 16:09:31 2024 -0500
+++ b/magick/version.h	Wed May 15 18:24:58 2024 -0500
@@ -38,8 +38,8 @@
 #define MagickLibVersion  0x282500
 #define MagickLibVersionText  "1.4"
 #define MagickLibVersionNumber 28,25,0
-#define MagickChangeDate   "20240515"
-#define MagickReleaseDate  "snapshot-20240515"
+#define MagickChangeDate   "20240516"
+#define MagickReleaseDate  "snapshot-20240516"
 
 /*
   The MagickLibInterfaceNewest and MagickLibInterfaceOldest defines
diff -r 5488b9864182 -r 320af918e5b3 www/ChangeLog.html
--- a/www/ChangeLog.html	Wed May 15 16:09:31 2024 -0500
+++ b/www/ChangeLog.html	Wed May 15 18:24:58 2024 -0500
@@ -38,6 +38,22 @@
 
 <div class="document" id="graphicsmagick-changelog">
 <h1 class="title">GraphicsMagick ChangeLog</h1>
+<dl class="simple">
+<dt>2024-05-16  Fojtik Jaroslav  &lt;<a class="reference external" href="mailto:JaFojtik&#37;&#52;&#48;yandex&#46;com">JaFojtik<span>&#64;</span>yandex<span>&#46;</span>com</a>&gt;</dt>
+<dd><ul class="simple">
+<li><p>coders/tiff.c: TIFFTAG_INKNAMES should have a first parameter of
+the type uint16_t.</p></li>
+</ul>
+</dd>
+</dl>
+<p>2024-05-15  Bob Friesenhahn  &lt;<a class="reference external" href="mailto:bfriesen&#37;&#52;&#48;simple&#46;dallas&#46;tx&#46;us">bfriesen<span>&#64;</span>simple<span>&#46;</span>dallas<span>&#46;</span>tx<span>&#46;</span>us</a>&gt;</p>
+<blockquote>
+<ul class="simple">
+<li><p>magick/utility.c (ExpandFilenames): Address Coverity 425853:
+&quot;Resource leaks (RESOURCE_LEAK) Variable &quot;filelist&quot; going out of
+scope leaks the storage it points to.&quot;.</p></li>
+</ul>
+</blockquote>
 <p>2024-05-15  Fojtik Jaroslav  &lt;<a class="reference external" href="mailto:JaFojtik&#37;&#52;&#48;yandex&#46;com">JaFojtik<span>&#64;</span>yandex<span>&#46;</span>com</a>&gt;</p>
 <blockquote>
 <ul class="simple">