GraphicsMagick: Mark MagickReverseBits() and MagickGetBitRevTabl...

GraphicsMagick Commits <[email protected]> Mon, 06 Jan 2025 08:33:57 -0600
Newsgroups gmane.comp.video.graphicsmagick.cvs
Message-ID <mailman.45098.1736174046.7833.graphicsmagick-commit@lists.sourceforge.net>
changeset 937bdb232bb9 in /hg/GraphicsMagick
details: http://hg.GraphicsMagick.org/hg/GraphicsMagick?cmd=changeset;node=937bdb232bb9
summary: Mark MagickReverseBits() and MagickGetBitRevTable() as deprecated since they have never been used.

diffstat:

 ChangeLog                              |  7 +++++++
 VisualMagick/installer/inc/version.isx |  4 ++--
 magick/magick_endian.c                 |  5 +++++
 magick/magick_endian.h                 |  4 ++--
 magick/version.h                       |  4 ++--
 www/ChangeLog.html                     |  9 +++++++++
 6 files changed, 27 insertions(+), 6 deletions(-)

diffs (94 lines):

diff -r a8073af22ef5 -r 937bdb232bb9 ChangeLog
--- a/ChangeLog	Sat Jan 04 09:56:09 2025 -0600
+++ b/ChangeLog	Mon Jan 06 08:31:49 2025 -0600
@@ -1,3 +1,10 @@
+2025-01-06  Bob Friesenhahn  <[email protected]>
+
+	* magick/magick_endian.c (MagickReverseBits): Function has never
+	been used for anything.  Mark it as deprecated.
+	MagickGetBitRevTable(): Function has never been used for anything.
+	Mark it as deprecated.
+
 2025-01-04  Bob Friesenhahn  <[email protected]>
 
 	* NEWS.txt: Update the news.
diff -r a8073af22ef5 -r 937bdb232bb9 VisualMagick/installer/inc/version.isx
--- a/VisualMagick/installer/inc/version.isx	Sat Jan 04 09:56:09 2025 -0600
+++ b/VisualMagick/installer/inc/version.isx	Mon Jan 06 08:31:49 2025 -0600
@@ -10,5 +10,5 @@
 
 #define public MagickPackageName "GraphicsMagick"
 #define public MagickPackageVersion "1.4"
-#define public MagickPackageVersionAddendum ".020250104"
-#define public MagickPackageReleaseDate "snapshot-20250104"
+#define public MagickPackageVersionAddendum ".020250106"
+#define public MagickPackageReleaseDate "snapshot-20250106"
diff -r a8073af22ef5 -r 937bdb232bb9 magick/magick_endian.c
--- a/magick/magick_endian.c	Sat Jan 04 09:56:09 2025 -0600
+++ b/magick/magick_endian.c	Mon Jan 06 08:31:49 2025 -0600
@@ -107,6 +107,11 @@
 }
 
 /*
+  FIXME: Nothing in GraphicsMagick is using MagickReverseBits() or
+  MagickGetBitRevTable() so they should be removed.
+*/
+
+/*
  * Bit reversal tables.  MagickBitRevTable[<byte>] gives
  * the bit reversed value of <byte>.  Used in various
  * places in the library when the FillOrder requires
diff -r a8073af22ef5 -r 937bdb232bb9 magick/magick_endian.h
--- a/magick/magick_endian.h	Sat Jan 04 09:56:09 2025 -0600
+++ b/magick/magick_endian.h	Mon Jan 06 08:31:49 2025 -0600
@@ -8,7 +8,7 @@
   Word-swapping functions.
 */
 extern MagickExport void
-  MagickReverseBits(unsigned char *cp, size_t n),
+  MagickReverseBits(unsigned char *cp, size_t n) MAGICK_FUNC_DEPRECATED,
   MagickSwabArrayOfDouble(double *dp, size_t n),
   MagickSwabArrayOfFloat(float *fp, size_t n),
   MagickSwabArrayOfUInt16(magick_uint16_t *wp, size_t n),
@@ -19,7 +19,7 @@
   MagickSwabUInt32(magick_uint32_t *lp);
 
 extern MagickExport const unsigned char
-  *MagickGetBitRevTable(int) MAGICK_FUNC_CONST;
+  *MagickGetBitRevTable(int) MAGICK_FUNC_CONST MAGICK_FUNC_DEPRECATED;
 
 /*
  * Local Variables:
diff -r a8073af22ef5 -r 937bdb232bb9 magick/version.h
--- a/magick/version.h	Sat Jan 04 09:56:09 2025 -0600
+++ b/magick/version.h	Mon Jan 06 08:31:49 2025 -0600
@@ -38,8 +38,8 @@
 #define MagickLibVersion  0x282502
 #define MagickLibVersionText  "1.4"
 #define MagickLibVersionNumber 28,25,2
-#define MagickChangeDate   "20250104"
-#define MagickReleaseDate  "snapshot-20250104"
+#define MagickChangeDate   "20250106"
+#define MagickReleaseDate  "snapshot-20250106"
 
 /*
   The MagickLibInterfaceNewest and MagickLibInterfaceOldest defines
diff -r a8073af22ef5 -r 937bdb232bb9 www/ChangeLog.html
--- a/www/ChangeLog.html	Sat Jan 04 09:56:09 2025 -0600
+++ b/www/ChangeLog.html	Mon Jan 06 08:31:49 2025 -0600
@@ -38,6 +38,15 @@
 
 <main id="graphicsmagick-changelog">
 <h1 class="title">GraphicsMagick ChangeLog</h1>
+<p>2025-01-06  Bob Friesenhahn  &lt;<a class="reference external" href="mailto:bfriesen&#37;&#52;&#48;simple&#46;dallas&#46;tx&#46;us">bfriesen<span>&#64;</span>simple<span>&#46;</span>dallas<span>&#46;</span>tx<span>&#46;</span>us</a>&gt;</p>
+<blockquote>
+<ul class="simple">
+<li><p>magick/magick_endian.c (MagickReverseBits): Function has never
+been used for anything.  Mark it as deprecated.
+MagickGetBitRevTable(): Function has never been used for anything.
+Mark it as deprecated.</p></li>
+</ul>
+</blockquote>
 <p>2025-01-04  Bob Friesenhahn  &lt;<a class="reference external" href="mailto:bfriesen&#37;&#52;&#48;simple&#46;dallas&#46;tx&#46;us">bfriesen<span>&#64;</span>simple<span>&#46;</span>dallas<span>&#46;</span>tx<span>&#46;</span>us</a>&gt;</p>
 <blockquote>
 <ul class="simple">