Re: Suspect code in magick/floats.c

On Fri, 26 Oct 2012, Ian Zimmerman wrote:

>
> I just switched from a 32 bit machine to a 64 bit one, and this file
> stopped compiling for me.  gcc complains about these lines:

To be sure, the compiler warnings have been annoying me but I had 
researched or done anything to avoid them.  Sorry about that.  The 
author previously told me that this was a run-time endian test 
described in some edition of Harbison and Steel's C Reference Manual 
book.

> In any case I hope you agree that the code is obscure at best and should
> be rewritten with memcmp() or something.  It also seems to be just an

Yes, it is obscure and causes a warning.

On some systems you may encounter a few other warnings due to use of 
setjmp/longjmp (in jpeg.c and png.c) that I have not figured out how 
to quench yet.

Bob
-- 
Bob Friesenhahn
[email protected], http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/

------------------------------------------------------------------------------
WINDOWS 8 is here. 
Millions of people.  Your app in 30 days.
Visit The Windows 8 Center at Sourceforge for all your go to resources.
http://windows8center.sourceforge.net/
join-generation-app-and-make-money-coding-fast/