thaytan gst-plugins-good: gst-plugins-good/ gst-plugins-good/gst/matroska/

[email protected]
Newsgroups gmane.comp.video.gstreamer.cvs
Message-ID <[email protected]>
CVS Root:       /cvs/gstreamer
Module:         gst-plugins-good
Changes by:     thaytan
Date:           Thu Nov 20 2008  14:30:55 UTC

Log message:
	* gst/matroska/matroska-mux.c:
	Fix NULL pointer dereference of an unset codec_id in the recently
	added Dirac paths

Modified files:
    .               : ChangeLog
    gst/matroska    : matroska-mux.c

Links:
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-good/ChangeLog.diff?r1=1.3822&r2=1.3823
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-good/gst/matroska/matroska-mux.c.diff?r1=1.75&r2=1.76

====Begin Diffs====
Index: matroska-mux.c
===================================================================
RCS file: /cvs/gstreamer/gst-plugins-good/gst/matroska/matroska-mux.c,v
retrieving revision 1.75
retrieving revision 1.76
diff -u -d -r1.75 -r1.76
--- matroska-mux.c	11 Nov 2008 12:18:23 -0000	1.75
+++ matroska-mux.c	20 Nov 2008 14:30:40 -0000	1.76
@@ -2099,7 +2099,8 @@
   }
 
   /* for dirac we have to queue up everything up to a picture unit */
-  if (strcmp (collect_pad->track->codec_id,
+  if (collect_pad->track->codec_id != NULL &&
+      strcmp (collect_pad->track->codec_id,
           GST_MATROSKA_CODEC_ID_VIDEO_DIRAC) == 0) {
     buf = gst_matroska_mux_handle_dirac_packet (mux, collect_pad, buf);
     if (!buf)
Index: ChangeLog
RCS file: /cvs/gstreamer/gst-plugins-good/ChangeLog,v
retrieving revision 1.3822
retrieving revision 1.3823
diff -u -d -r1.3822 -r1.3823
--- ChangeLog	20 Nov 2008 13:58:41 -0000	1.3822
+++ ChangeLog	20 Nov 2008 14:30:35 -0000	1.3823
@@ -1,5 +1,11 @@
 2008-11-20  Jan Schmidt  <[email protected]>
+	* gst/matroska/matroska-mux.c:
+	Fix NULL pointer dereference of an unset codec_id in the recently 
+	added Dirac paths
+
+2008-11-20  Jan Schmidt  <[email protected]>
 	* tests/check/Makefile.am:
 	Just keep disabling elements that hang the states test until it
 	works.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.