felipec gst-openmax: gst-openmax/omx/

CVS Root:       /cvs/gstreamer
Module:         gst-openmax
Changes by:     felipec
Date:           Thu Nov 20 2008  16:19:40 UTC

Log message:
Allow child classes to override the share_output_buffer workaround.
Some components modify nOffset, which messes up everything.

Modified files:
    omx             : gstomx_base_filter.c gstomx_base_filter.h

Links:
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-openmax/omx/gstomx_base_filter.c.diff?r1=1.57&r2=1.58
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-openmax/omx/gstomx_base_filter.h.diff?r1=1.15&r2=1.16

====Begin Diffs====
Index: gstomx_base_filter.c
===================================================================
RCS file: /cvs/gstreamer/gst-openmax/omx/gstomx_base_filter.c,v
retrieving revision 1.57
retrieving revision 1.58
diff -u -d -r1.57 -r1.58
--- gstomx_base_filter.c	20 Nov 2008 16:13:48 -0000	1.57
+++ gstomx_base_filter.c	20 Nov 2008 16:19:25 -0000	1.58
@@ -27,7 +27,6 @@
 #include <string.h> /* For memcpy */
 
 static gboolean share_input_buffer = FALSE;
-static gboolean share_output_buffer = FALSE;
 enum
 {
@@ -377,7 +376,7 @@
                     omx_buffer->nFilledLen = 0;
-                    if (share_output_buffer)
+                    if (self->share_output_buffer)
                     {
                         GST_WARNING_OBJECT (self, "couldn't zero-copy");
                         g_free (omx_buffer->pBuffer);
@@ -408,7 +407,7 @@
             goto leave;
         }
-        if (share_output_buffer &&
+        if (self->share_output_buffer &&
             !omx_buffer->pBuffer &&
             omx_buffer->nOffset == 0)
         {
@@ -437,7 +436,7 @@
             }
             !omx_buffer->pBuffer)
             GST_WARNING_OBJECT (self, "no input buffer to share");
Index: gstomx_base_filter.h
RCS file: /cvs/gstreamer/gst-openmax/omx/gstomx_base_filter.h,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -d -r1.15 -r1.16
--- gstomx_base_filter.h	23 Jun 2008 12:38:55 -0000	1.15
+++ gstomx_base_filter.h	20 Nov 2008 16:19:25 -0000	1.16
@@ -56,6 +56,8 @@
     GstOmxBaseFilterCb omx_setup;
     GstFlowReturn last_pad_push_return;
     GstBuffer *codec_data;
+
+    gboolean share_output_buffer; /** @todo this is hack, OpenMAX IL spec should be revised. */
 };
 struct GstOmxBaseFilterClass

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/