CVS Root: /cvs/gstreamer
Module: gst-openmax
Changes by: felipec
Date: Thu Nov 20 2008 16:51:25 UTC
Log message:
Fix initialization of buffers for processing.
This fixes a longstanding issue with seeking.
Only input buffers should be saved in the port queue, output buffers
should be sent directly to omx.
Before, the output buffers where saved in the port queue, so the output
thread was trying to process them. This is not a big issue for the
initial buffers because they are empty, but in the middle of a flush
they are not, so the buffers before the flush where pushed to the sink.
Modified files:
omx : gstomx_util.c
Links:
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-openmax/omx/gstomx_util.c.diff?r1=1.42&r2=1.43
====Begin Diffs====
Index: gstomx_util.c
===================================================================
RCS file: /cvs/gstreamer/gst-openmax/omx/gstomx_util.c,v
retrieving revision 1.42
retrieving revision 1.43
diff -u -d -r1.42 -r1.43
--- gstomx_util.c 20 Nov 2008 16:42:08 -0000 1.42
+++ gstomx_util.c 20 Nov 2008 16:51:10 -0000 1.43
@@ -528,7 +528,12 @@
omx_buffer = port->buffers[i];
- got_buffer (port->core, port, omx_buffer);
+ /* If it's an input port we will need to fill the buffer, so put it in
+ * the queue, otherwise send to omx for processing (fill it up). */
+ if (port->type == GOMX_PORT_INPUT)
+ got_buffer (port->core, port, omx_buffer);
+ else
+ g_omx_port_release_buffer (port, omx_buffer);
}
}
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.