ensonic gst-plugins-good: gst-plugins-good/ gst-plugins-good/ext/pulse/

[email protected]
Newsgroups gmane.comp.video.gstreamer.cvs
Message-ID <[email protected]>
CVS Root:       /cvs/gstreamer
Module:         gst-plugins-good
Changes by:     ensonic
Date:           Sun Nov 23 2008  15:08:59 UTC

Log message:
	* ext/pulse/pulsesink.c:
	  Change #if 0 to something more expresive and add pointer to related
	  bug ticket.

Modified files:
    .               : ChangeLog
    ext/pulse       : pulsesink.c

Links:
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-good/ChangeLog.diff?r1=1.3829&r2=1.3830
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-good/ext/pulse/pulsesink.c.diff?r1=1.10&r2=1.11

====Begin Diffs====
Index: ChangeLog
===================================================================
RCS file: /cvs/gstreamer/gst-plugins-good/ChangeLog,v
retrieving revision 1.3829
retrieving revision 1.3830
diff -u -d -r1.3829 -r1.3830
--- ChangeLog	23 Nov 2008 11:17:01 -0000	1.3829
+++ ChangeLog	23 Nov 2008 15:08:43 -0000	1.3830
@@ -1,3 +1,9 @@
+2008-11-23  Stefan Kost  <[email protected]>
+
+	* ext/pulse/pulsesink.c:
+	  Change #if 0 to something more expresive and add pointer to related
+	  bug ticket.
 2008-11-23  Sebastian Dröge  <[email protected]>
 
 	Patch by: Tal Shalif <tshalif at nargila dot org>
Index: pulsesink.c
RCS file: /cvs/gstreamer/gst-plugins-good/ext/pulse/pulsesink.c,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -d -r1.10 -r1.11
--- pulsesink.c	3 Oct 2008 16:13:32 -0000	1.10
+++ pulsesink.c	23 Nov 2008 15:08:45 -0000	1.11
@@ -61,6 +61,12 @@
 GST_DEBUG_CATEGORY_EXTERN (pulse_debug);
 #define GST_CAT_DEFAULT pulse_debug
+/* according to
+ * http://www.pulseaudio.org/ticket/314
+ * we need pulse-0.9.12 to use sink volume properties
+ */
+/*#define HAVE_PULSE_0_9_12 */
 enum
 {
   PROP_SERVER = 1,
@@ -239,7 +245,7 @@
       g_param_spec_string ("device-name", "Device name",
           "Human-readable name of the sound device", NULL,
           G_PARAM_READABLE | G_PARAM_STATIC_STRINGS));
-#if 0
+#ifdef HAVE_PULSE_0_9_12
   g_object_class_install_property (gobject_class,
       PROP_VOLUME,
       g_param_spec_double ("volume", "Volume",
@@ -329,7 +335,7 @@
   G_OBJECT_CLASS (parent_class)->dispose (object);
 }
 static void
 gst_pulsesink_set_volume (GstPulseSink * pulsesink, gdouble volume)
@@ -401,7 +407,7 @@
       pulsesink->device = g_value_dup_string (value);
       break;
     case PROP_VOLUME:
       gst_pulsesink_set_volume (pulsesink, g_value_get_double (value));
@@ -436,7 +442,7 @@
         g_value_set_string (value, NULL);
       g_value_set_double (value, gst_pulsesink_get_volume (pulsesink));
@@ -637,7 +643,7 @@
   pa_threaded_mainloop_unlock (pulsesink->mainloop);
   gst_pulsesink_set_volume (pulsesink, pulsesink->volume);
 #endif
@@ -911,7 +917,7 @@
     case GST_STATE_CHANGE_READY_TO_NULL:
       if (this->mixer) {
         this->volume = gst_pulsesink_get_volume (this);
         gst_pulsemixer_ctrl_free (this->mixer);

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

_______________________________________________
gstreamer-cvs-verbose mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs-verbose
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.