CVS Root: /cvs/gstreamer
Module: gst-plugins-base
Changes by: wtay
Date: Thu Nov 27 2008 16:47:55 UTC
Log message:
* gst-libs/gst/audio/gstbaseaudiosrc.c:
(gst_base_audio_src_get_offset), (gst_base_audio_src_create):
Avoid nasty int overflows after about 12 hours and 25 minutes when these
code paths are triggered.
A free beer to Håvard Graff for finding this!
Modified files:
. : ChangeLog
gst-libs/gst/audio: gstbaseaudiosrc.c
Links:
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-base/ChangeLog.diff?r1=1.4219&r2=1.4220
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-base/gst-libs/gst/audio/gstbaseaudiosrc.c.diff?r1=1.49&r2=1.50
====Begin Diffs====
Index: ChangeLog
===================================================================
RCS file: /cvs/gstreamer/gst-plugins-base/ChangeLog,v
retrieving revision 1.4219
retrieving revision 1.4220
diff -u -d -r1.4219 -r1.4220
--- ChangeLog 27 Nov 2008 11:16:42 -0000 1.4219
+++ ChangeLog 27 Nov 2008 16:47:40 -0000 1.4220
@@ -1,5 +1,13 @@
2008-11-27 Wim Taymans <[email protected]>
+ * gst-libs/gst/audio/gstbaseaudiosrc.c:
+ (gst_base_audio_src_get_offset), (gst_base_audio_src_create):
+ Avoid nasty int overflows after about 12 hours and 25 minutes when these
+ code paths are triggered.
+ A free beer to Håvard Graff for finding this!
+
+2008-11-27 Wim Taymans <[email protected]>
Patch by: 이문형 <iwings at gmail dot com>
* gst-libs/gst/rtsp/gstrtspconnection.c:
Index: gstbaseaudiosrc.c
RCS file: /cvs/gstreamer/gst-plugins-base/gst-libs/gst/audio/gstbaseaudiosrc.c,v
retrieving revision 1.49
retrieving revision 1.50
diff -u -d -r1.49 -r1.50
--- gstbaseaudiosrc.c 8 Oct 2008 15:30:33 -0000 1.49
+++ gstbaseaudiosrc.c 27 Nov 2008 16:47:41 -0000 1.50
@@ -718,7 +718,7 @@
if (diff >= segtotal) {
GST_DEBUG_OBJECT (src, "dropped, align to segment %d", segdone);
/* sample would be dropped, position to next playable position */
- sample = (segdone - segtotal + 1) * sps;
+ sample = ((guint64) (segdone - segtotal + 1)) * sps;
}
return sample;
@@ -922,7 +922,7 @@
ringbuffer->segbase -= segment_diff;
/* we calculate the new sample value */
- new_sample = new_first_segment * sps;
+ new_sample = ((guint64) new_first_segment) * sps;
/* and get the relative time to this -> our new timestamp */
timestamp =
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
gstreamer-cvs-verbose mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs-verbose
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.