slomo gstreamer: gstreamer/ gstreamer/gst/

CVS Root:       /cvs/gstreamer
Module:         gstreamer
Changes by:     slomo
Date:           Tue Dec 09 2008  16:24:13 UTC

Log message:
* gst/gstutils.c: (gst_element_get_compatible_pad):
Fix a caps memory leak introduced by the last change.

Modified files:
    .               : ChangeLog
    gst             : gstutils.c

Links:
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.4189&r2=1.4190
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstutils.c.diff?r1=1.190&r2=1.191

====Begin Diffs====
Index: ChangeLog
===================================================================
RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v
retrieving revision 1.4189
retrieving revision 1.4190
diff -u -d -r1.4189 -r1.4190
--- ChangeLog	9 Dec 2008 15:45:34 -0000	1.4189
+++ ChangeLog	9 Dec 2008 16:23:56 -0000	1.4190
@@ -1,6 +1,11 @@
 2008-12-09  Sebastian Dröge  <[email protected]>
 
 	* gst/gstutils.c: (gst_element_get_compatible_pad):
+	Fix a caps memory leak introduced by the last change.
+
+2008-12-09  Sebastian Dröge  <[email protected]>
+	* gst/gstutils.c: (gst_element_get_compatible_pad):
 	Check if the caps of the pads are compatible before returning
 	a pad and claiming it is compatible. This, among other things,
 	fixes a bug with gst-launch where an incompatible pad is chosen
Index: gstutils.c
RCS file: /cvs/gstreamer/gstreamer/gst/gstutils.c,v
retrieving revision 1.190
retrieving revision 1.191
diff -u -d -r1.190 -r1.191
--- gstutils.c	9 Dec 2008 15:45:36 -0000	1.190
+++ gstutils.c	9 Dec 2008 16:23:58 -0000	1.191
@@ -989,6 +989,8 @@
           intersection = temp2;
           if (!gst_caps_is_empty (intersection)) {
+            gst_caps_unref (intersection);
             GST_CAT_DEBUG (GST_CAT_ELEMENT_PADS,
                 "found existing unlinked compatible pad %s:%s",
                 GST_DEBUG_PAD_NAME (current));
@@ -996,6 +998,7 @@
             return current;
           }
+          gst_caps_unref (intersection);
         }
         GST_CAT_DEBUG (GST_CAT_ELEMENT_PADS, "unreffing pads");

------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/

_______________________________________________
gstreamer-cvs-verbose mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs-verbose