wtay gst-plugins-base: gst-plugins-base/ gst-plugins-base/gst/playback/

CVS Root:       /cvs/gstreamer
Module:         gst-plugins-base
Changes by:     wtay
Date:           Wed Dec 10 2008  18:43:46 UTC

Log message:
* gst/playback/gstplaybin2.c: (pad_added_cb):
Error out with a missing-plugin error when the input-selector was not
found.
* gst/playback/gstplaysink.c: (gst_play_sink_reconfigure):
Indentation.

Modified files:
    .               : ChangeLog
    gst/playback    : gstplaybin2.c gstplaysink.c

Links:
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-base/ChangeLog.diff?r1=1.4240&r2=1.4241
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-base/gst/playback/gstplaybin2.c.diff?r1=1.28&r2=1.29
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-base/gst/playback/gstplaysink.c.diff?r1=1.21&r2=1.22

====Begin Diffs====
Index: ChangeLog
===================================================================
RCS file: /cvs/gstreamer/gst-plugins-base/ChangeLog,v
retrieving revision 1.4240
retrieving revision 1.4241
diff -u -d -r1.4240 -r1.4241
--- ChangeLog	10 Dec 2008 17:39:31 -0000	1.4240
+++ ChangeLog	10 Dec 2008 18:43:30 -0000	1.4241
@@ -1,5 +1,14 @@
 2008-12-10  Wim Taymans  <[email protected]>
 
+	* gst/playback/gstplaybin2.c: (pad_added_cb):
+	Error out with a missing-plugin error when the input-selector was not
+	found.
+
+	* gst/playback/gstplaysink.c: (gst_play_sink_reconfigure):
+	Indentation.
+2008-12-10  Wim Taymans  <[email protected]>
 	* gst/playback/gstplaysink.c: (gst_play_sink_class_init),
 	(gst_play_sink_dispose), (gst_play_sink_finalize), (try_element),
 	(gen_video_chain), (gen_audio_chain), (gst_play_sink_reconfigure),
Index: gstplaybin2.c
RCS file: /cvs/gstreamer/gst-plugins-base/gst/playback/gstplaybin2.c,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -d -r1.28 -r1.29
--- gstplaybin2.c	25 Nov 2008 11:00:55 -0000	1.28
+++ gstplaybin2.c	10 Dec 2008 18:43:31 -0000	1.29
@@ -1767,9 +1767,14 @@
   }
 no_selector:
   {
-    GST_ERROR_OBJECT (playbin, "could not create selector for pad %s:%s",
-        GST_DEBUG_PAD_NAME (pad));
     GST_SOURCE_GROUP_UNLOCK (group);
+    gst_element_post_message (GST_ELEMENT_CAST (playbin),
+        gst_missing_element_message_new (GST_ELEMENT_CAST (playbin),
+            "input-selector"));
+    GST_ELEMENT_ERROR (playbin, CORE, MISSING_PLUGIN,
+        (_("Missing element '%s' - check your GStreamer installation."),
+            "input-selector"), (NULL));
     return;
 link_failed:
Index: gstplaysink.c
RCS file: /cvs/gstreamer/gst-plugins-base/gst/playback/gstplaysink.c,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -d -r1.21 -r1.22
--- gstplaysink.c	10 Dec 2008 17:39:32 -0000	1.21
+++ gstplaysink.c	10 Dec 2008 18:43:32 -0000	1.22
@@ -1306,8 +1306,8 @@
     GST_DEBUG_OBJECT (playsink, "adding visualisation");
     srcpad =
-        gst_element_get_static_pad (GST_ELEMENT_CAST (playsink->vischain->chain.
-            bin), "src");
+        gst_element_get_static_pad (GST_ELEMENT_CAST (playsink->vischain->
+            chain.bin), "src");
     add_chain (GST_PLAY_CHAIN (playsink->vischain), TRUE);
     gst_pad_link (playsink->audio_tee_vissrc, playsink->vischain->sinkpad);
     gst_pad_link (srcpad, playsink->videochain->sinkpad);

------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/