bilboed gstreamer: gstreamer/ gstreamer/libs/gst/base/

[email protected] Sat, 3 Jan 2009 10:39:52 -0800 (PST)
Newsgroups gmane.comp.video.gstreamer.cvs
Message-ID <[email protected]>
CVS Root:       /cvs/gstreamer
Module:         gstreamer
Changes by:     bilboed
Date:           Sat Jan 03 2009  18:39:52 UTC

Log message:
* libs/gst/base/gstcollectpads.c: (gst_collect_pads_available):
Use the name of the pads instead of a pointer, helps in debugging.

Modified files:
    .               : ChangeLog
    libs/gst/base   : gstcollectpads.c

Links:
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.4210&r2=1.4211
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/libs/gst/base/gstcollectpads.c.diff?r1=1.54&r2=1.55

====Begin Diffs====
Index: ChangeLog
===================================================================
RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v
retrieving revision 1.4210
retrieving revision 1.4211
diff -u -d -r1.4210 -r1.4211
--- ChangeLog	3 Jan 2009 18:16:52 -0000	1.4210
+++ ChangeLog	3 Jan 2009 18:39:36 -0000	1.4211
@@ -1,5 +1,10 @@
 2009-01-03  Edward Hervey  <[email protected]>
 
+	* libs/gst/base/gstcollectpads.c: (gst_collect_pads_available):
+	Use the name of the pads instead of a pointer, helps in debugging.
+
+2009-01-03  Edward Hervey  <[email protected]>
 	* gst/gstindex.c: (gst_index_get_type):
 	Add a debugging category for GstIndex, first little step in making
 	indexing top-notch.
Index: gstcollectpads.c
RCS file: /cvs/gstreamer/gstreamer/libs/gst/base/gstcollectpads.c,v
retrieving revision 1.54
retrieving revision 1.55
diff -u -d -r1.54 -r1.55
--- gstcollectpads.c	29 Feb 2008 12:41:28 -0000	1.54
+++ gstcollectpads.c	3 Jan 2009 18:39:38 -0000	1.55
@@ -768,19 +768,20 @@
     /* ignore pad with EOS */
     if (G_UNLIKELY (pdata->abidata.ABI.eos)) {
-      GST_DEBUG ("pad %p is EOS", pdata);
+      GST_DEBUG ("pad %s:%s is EOS", GST_DEBUG_PAD_NAME (pdata->pad));
       continue;
     }
     /* an empty buffer without EOS is weird when we get here.. */
     if (G_UNLIKELY ((buffer = pdata->buffer) == NULL)) {
-      GST_WARNING ("pad %p has no buffer", pdata);
+      GST_WARNING ("pad %s:%s has no buffer", GST_DEBUG_PAD_NAME (pdata->pad));
       goto not_filled;
     /* this is the size left of the buffer */
     size = GST_BUFFER_SIZE (buffer) - pdata->pos;
-    GST_DEBUG ("pad %p has %d bytes left", pdata, size);
+    GST_DEBUG ("pad %s:%s has %d bytes left",
+        GST_DEBUG_PAD_NAME (pdata->pad), size);
     /* need to return the min of all available data */
     if (size < result)

------------------------------------------------------------------------------