bilboed gnonlin: gnonlin/ gnonlin/gnl/

CVS Root:       /cvs/gstreamer
Module:         gnonlin
Changes by:     bilboed
Date:           Wed Jan 07 2009  12:12:51 UTC

Log message:
Patch by: Alessandro Decina <[email protected]>
* gnl/gnlcomposition.c: (gnl_composition_ghost_pad_set_target):
Release objects lock temporarily when emitting no-more-pads.
This should not affect anything considering that the composition is
in the process of being built at that point and no actions should
be attempting to modify it while that lock is released.
Fixes #566796

Modified files:
    .               : ChangeLog
    gnl             : gnlcomposition.c

Links:
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gnonlin/ChangeLog.diff?r1=1.217&r2=1.218
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gnonlin/gnl/gnlcomposition.c.diff?r1=1.80&r2=1.81

====Begin Diffs====
Index: ChangeLog
===================================================================
RCS file: /cvs/gstreamer/gnonlin/ChangeLog,v
retrieving revision 1.217
retrieving revision 1.218
diff -u -d -r1.217 -r1.218
--- ChangeLog	28 Dec 2008 15:28:39 -0000	1.217
+++ ChangeLog	7 Jan 2009 12:12:32 -0000	1.218
@@ -1,3 +1,13 @@
+2009-01-07  Edward Hervey  <[email protected]>
+
+	Patch by: Alessandro Decina <[email protected]>
+	* gnl/gnlcomposition.c: (gnl_composition_ghost_pad_set_target):
+	Release objects lock temporarily when emitting no-more-pads.
+	This should not affect anything considering that the composition is
+	in the process of being built at that point and no actions should
+	be attempting to modify it while that lock is released.
+	Fixes #566796
 2008-12-28  Edward Hervey  <[email protected]>
 
 	* gnl/gnlcomposition.c: (refine_start_stop_in_region_above_priority):
Index: gnlcomposition.c
RCS file: /cvs/gstreamer/gnonlin/gnl/gnlcomposition.c,v
retrieving revision 1.80
retrieving revision 1.81
diff -u -d -r1.80 -r1.81
--- gnlcomposition.c	28 Dec 2008 15:28:40 -0000	1.80
+++ gnlcomposition.c	7 Jan 2009 12:12:36 -0000	1.81
@@ -1000,8 +1000,11 @@
     gst_pad_set_active (comp->private->ghostpad, TRUE);
     if (!(gst_element_add_pad (GST_ELEMENT (comp), comp->private->ghostpad)))
       GST_WARNING ("Couldn't add the ghostpad");
-    else
+    else {
+      COMP_OBJECTS_UNLOCK (comp);
       gst_element_no_more_pads (GST_ELEMENT (comp));
+      COMP_OBJECTS_LOCK (comp);
+    }
   }
   GST_DEBUG_OBJECT (comp, "END");
 }

------------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It is the best place to buy or sell services for
just about anything Open Source.
http://p.sf.net/sfu/Xq1LFB