Re: [PATCH] zr36067: Debugging cleanups

Hi Jean,

On May 7, 2007, at 5:05 AM, Jean Delvare wrote:
> * Use a single global variable to handle the debug level. This makes
>   the driver a bit smaller (by about 800 bytes on x86_64), thanks to
>   one less level of indirection on every use.
[..]
> +int debug = 1;

This is not good, imagine another driver or kernel particle using a  
(global) variable called debug. Last time I did this, there were 3 of  
them. :-). Please call it something else.

The reason other drivers use debug is b/c their debug is static. The  
reason I did this zr_debug + debug hack is b/c it allows the debug  
name without having a debug variable.

Ronald


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/