Re: [PATCH] zr36067: Debugging cleanups (updated)
"Ronald S. Bultje" <[email protected]>
| Newsgroups | gmane.comp.video.mjpeg.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Jean, On May 23, 2007, at 9:06 AM, Jean Delvare wrote: > On Wed, 23 May 2007 08:17:46 -0400, Ronald S. Bultje wrote: >> On May 23, 2007, at 7:35 AM, Jean Delvare wrote: >>> * The debug level is between 0 and 5, not 0 and 4. >> >> This part should not be applied though, since the only use of 5 is an >> easter egg, and I think the range use is only descriptive. Can you >> attach your next patch so I can pick it and move it to LKML? The rest >> of the patch is fine, so let's send it in. > > I count 5 occurrences of dprintk(5, ...) in the driver, one is indeed > an Easter Egg, but the others aren't. Ugh, I suck. Let's make that egg a 6 then. :-). Otherwise I like the patch (and the size decrease along with it :-) ). Ronald ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/