Re: [PATCH] zr36067: Debugging cleanups (updated again)

On Wed, 23 May 2007, Jean Delvare wrote:
> On Wed, 23 May 2007 09:12:38 -0400, Ronald S. Bultje wrote:
> > On May 23, 2007, at 9:06 AM, Jean Delvare wrote:
> > > On Wed, 23 May 2007 08:17:46 -0400, Ronald S. Bultje wrote:
> > >> On May 23, 2007, at 7:35 AM, Jean Delvare wrote:
> > >>> * The debug level is between 0 and 5, not 0 and 4.
> > >>
> > >> This part should not be applied though, since the only use of 5 is an
> > >> easter egg, and I think the range use is only descriptive. Can you
> > >> attach your next patch so I can pick it and move it to LKML? The rest
> > >> of the patch is fine, so let's send it in.
> > >
> > > I count 5 occurrences of dprintk(5, ...) in the driver, one is indeed
> > > an Easter Egg, but the others aren't.
> >
> > Ugh, I suck. Let's make that egg a 6 then. :-).
>
> OK, I've done that. New patch below.
>
> > Otherwise I like the patch (and the size decrease along with it :-) ).
>
> And I have a couple more to come, but I'll let Trent commit his changes
> first so that my cleanups don't get in the way of his more important
> fixes.

This looks good to me.  Ronald, if you send me your ack, I will pull this into
the v4l-dvb repository.

I've also got a question about the internal driver operation.

The private data for the file handled passed to file opts functions (e.g.
ioctl) is a struct zoran_fh.  One of the fields in this struct is "struct
zoran_v4l_struct v4l_buffers", which describes the state of the v4l(2) capture
buffers.

The zoran_fh also has a pointer to a "struct zoran", which has the state for
the chip.  This struct _also_ has a v4l_buffers field for the same information
as the field in the file handle specific data.

What is the difference between the two different places the v4l buffers are
described?  From what I can tell, the v4l_buffers in the struct zoran is the
real one.  The copy in the file handle appears to never change during capture.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/