Re: [PATCH] zoran: more fixes

Jean Delvare <[email protected]> Sat, 9 Jun 2007 22:09:42 +0200
Newsgroups gmane.comp.video.mjpeg.devel
Message-ID <[email protected]>
On Fri, 1 Jun 2007 14:18:29 -0700 (PDT), Trent Piepho wrote:
> I figured out what was keeping tvtime from being able to switch inputs.  It
> was a problem with restarting capture after stopping it like I thought.
> The fix ended up being simple, but finding what exactly was the problem was
> a pain.
> 
> With this patch tvtime is working ok.  You will of course need to make sure
> the horizontal resolution is small enough to fit in the v4l capture buffer.
> 
> mplayer works for uncompressed capture.  mplayer's v4l2 driver has a flaw in
> that it doesn't set format/width/height in one single call to S_FMT, but tries
> to set them one at a time.  So if you request 160x120 RGB32, it will first try
> S_FMT 640x480 RGB32.  While 160x120 will fit in a 128k buffer, 640x480 wont,
> so the S_FMT fails.  The zoran driver could do a better job of handling S_FMT
> calls that aren't possible.

I can confirm that, with this patch, I can now change the input in
tvtime. Great work Trent!

Thanks,
-- 
Jean Delvare

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/