Re: [PATCH] zr36067: Debugging cleanups (updated again)

On Sat, 9 Jun 2007, Jean Delvare wrote:
> On Sat, 26 May 2007 07:17:44 -0700 (PDT), Trent Piepho wrote:
> > I was able to change the driver's kmalloc() limit from 128k to 1024k, and it
> > appeared to be able to allocate the larger memory region fine.
>
> For the records, I tried increasing the max kmalloc size too. 512 kB
> buffers work nicely. 1024 kB buffers work too, but /proc/buddyinfo
> shows they are rare, so I can't ask for too many buffers, and maybe at
> some point they will no longer be available.
>
> Still, this demonstrates that there would be a practical benefit in
> removing this arbitrary 128 kB limit from the driver. I'll try to come
> up with a patch tomorrow.

I think the 128k limit is from some time ago, when 64MB would be a typical
amount of memory for a system.  Allocations >128k would be very unlikely to
succeed, while now it's entirely possible.  It makes a lot more sense to try
kmalloc first and only have buffer allocation fail if kmalloc fails.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/