Re: [PATCH] Make mjpegtools build with LDFLAGS=-Wl, --as-needed

On Sat, 22 Mar 2008, Fabian Greffrath wrote:

diff -Nur mjpegtools-1.9.0rc3/mpeg2enc/Makefile.am mjpegtools-1.9.0rc3.new/mpeg2enc/Makefile.am
--- mjpegtools-1.9.0rc3/mpeg2enc/Makefile.am
+++ mjpegtools-1.9.0rc3.new/mpeg2enc/Makefile.am
@@ -78,7 +78,7 @@
	... 
-libmpeg2encpp_la_LIBADD = $(LIBMJPEGUTILS)
+libmpeg2encpp_la_LIBADD = $(LIBMJPEGUTILS) -lpthread
 
	Unacceptable.  Not all systems have -lpthread because the threads
	routines are in the system libraries.  

	If -lpthreads has not been needed  until now why is it suddenly
	necessary to add it?  

	The other pportions of the patch look ok but hardcoding -lpthreads
	is not correct (or necessary from what I can see)

	Cheers,
	Steven Schultz


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/