Re: mjpegtools patch for better support of Solaris and Sun Studio

On Fri, 18 Sep 2009, Milan Jurik wrote:

> It seems the patches were lost during forward, so I attached them. Thank
> you info :-)

	It appears that the patches were not created using the current
	CVS version of mjpegtools.   Some of the changes were already
	made and at least one patch fails to apply.  

> > > based on my limited set of C++, I created attached set of patches which
> > > enables Solaris/Sun Studio support.
> > >
> > > mjpegtools-01-progname.diff - no ideal support for missing __progname
> > > mjpegtools-02-alloca.diff - <alloca.h> missing

	That change is harmless (but Sun really should know by this time
	that alloca.h is obsolete and should not be used).  This change has
	been checked in to CVS.

> > > mjpegtools-04-suncc.diff
> > > - std:: used for std namespace functions
> > > - sizeof with non-constant array size is not supported
> > > - const char * were needed
> > > - SetRegion2D was not visible in some templates

	The change to mplex/lpcmstrm_in.cpp was already in CVS.  The change
	to SetRegon2D.hh fails to apply.  The change to Allocator.hh applied
	but was offset 3 lines.

	y4mdenoise has been heavily modified since 1.9.0 was released.

	Please make patches using the current CVS rather than earlier releases.

> > > I know these patches are not ideal but it can be inspiration for better
> > > Solaris support and nothing is in collision with GCC.

	When did Sun remove *__progname?  Mjpegtools has been built on 
	Solaris in the past.  I am not enthusiastic about compiling the program
	name string into the program because if you copy/build (for debugging
	purposes) the program to a different file the program name string
	becomes wrong.  More research is needed to find out how to implement
	(or what Sun offers as a replacement) *__progname on Solaris.  

	So for now the __progname changes have not been checked in to CVS.

	Cheers,
	Steven Schultz


------------------------------------------------------------------------------
Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
http://p.sf.net/sfu/devconf