Re: Unnecessary check for mmap/trigger in audiolib.c

Martin Samuelsson <[email protected]> Fri, 17 Jun 2011 00:22:02 +0200
Newsgroups gmane.comp.video.mjpeg.devel
Message-ID <20110617002202.755664e4@kvantarell>
On Thu, 16 Jun 2011 19:35:40 +0200
Bernhard Praschinger <[email protected]> wrote:

> Hallo
> 
> It takes most of the time a little bit longer-

I know the feeling...

> >> shouldn't. My proposed patch takes care of that, skipping the check when read/write
> >> is requested instead of mmap.

> I have just added you patch to the CVS.

Nice!

> > If I do not waitpid or pthread_join, lavplay exits instead of hanging indefinitely.
> > I interpret this as the audio thread (do_audio()) being locked up in some way,
> > not able to react to exit_flag, and thus not able to exit, leaving lavplay
> > waiting forever for it to exit
> >
> The conclusion sounds correct. But I have no idea of how to proceed.

If nobody beats me to it, I'll take a look. Sometime. :)

Regards,
/Sam

> 
> auf hoffentlich bald,
> 
> Berni the Chaos of Woodquarter
> 
> Email: [email protected]
> www: http://www.lysator.liu.se/~gz/bernhard
> 
> ------------------------------------------------------------------------------
> EditLive Enterprise is the world's most technically advanced content
> authoring tool. Experience the power of Track Changes, Inline Image
> Editing and ensure content is compliant with Accessibility Checking.
> http://p.sf.net/sfu/ephox-dev2dev
> _______________________________________________
> Mjpeg-developer mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mjpeg-developer

------------------------------------------------------------------------------
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev