Re: [PATCH 1/7] asm-generic, media: allow COMPILE_TEST with virt_to_bus
Arnd Bergmann <[email protected]>
| Newsgroups | gmane.comp.video.mjpeg.user,gmane.linux.kernel.cross-arch,gmane.linux.drivers.video-input-infrastructure |
|---|---|
| Message-ID | <CAK8P3a1c044Tx9oCHyhR=-d4v67ijuwgubZPx52e4NDDETRe0Q@mail.gmail.com> |
On Fri, Apr 20, 2018 at 7:42 PM, Mauro Carvalho Chehab <[email protected]> wrote: > The virt_to_bus/bus_to_virt macros are arch-specific. Some > archs don't support it. Yet, as it is interesting to allow > doing compilation tests on non-ia32/ia64 archs, provide a > fallback for such archs. > > While here, enable COMPILE_TEST for two media drivers that > depends on it. > > Signed-off-by: Mauro Carvalho Chehab <[email protected]> I'd prefer not to do this: virt_to_bus() is deprecated for good reasons, and I'd rather see the drivers fixed to use dma-mapping.h correctly. One problem with your patch is that not all architectures include asm-generic/io.h, so it likely breaks allmodconfig builds on architectures that don't use that file and don't provide virt_to_bus() either. Arnd ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot