Re: [PATCH 1/4] staging: media: zoran: add zrdev_dbg() macros
Ian Cowan <[email protected]> Sun, 24 Apr 2022 21:22:30 -0400
| Newsgroups | gmane.linux.drivers.video-input-infrastructure,gmane.comp.video.mjpeg.user |
|---|---|
| Message-ID | <YmX31vg+lCx6rsKF@fedora> |
On Sun, Apr 24, 2022 at 09:17:22PM +0200, LABBE Corentin wrote: > Hello > > Thanks for your patchs, removing dprintk is a good idea. > Please use pci_xxx() instead of dev_xxx() to be consistent with the rest of the driver. > The comment title is misleading, zrdev_err is not about debugging. What about Logging macros ? > > Regards > I have made those modifications, and I will resubmit patches 1 and 2 shortly. Those are the only patches that affected by this change; 3 and 4 will not change. Thanks, Ian