Re: [PATCH] media: staging: media: zoran: Removed braces for single statement block

Philipp Hortmann <[email protected]> Fri, 22 Jul 2022 06:54:48 +0200

Newsgroups	gmane.linux.drivers.video-input-infrastructure,gmane.comp.video.mjpeg.user,gmane.linux.kernel
Message-ID	<[email protected]>

On 7/21/22 17:00, Abhijeet Srivastava wrote:
> Warning found by checkpatch.pl script.
> 
> Signed-off-by: Abhijeet Srivastava <[email protected]>
> ---
>   drivers/staging/media/zoran/zoran_card.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/zoran/zoran_card.c b/drivers/staging/media/zoran/zoran_card.c
> index 26f978a1cc72..0c138d47d0c3 100644
> --- a/drivers/staging/media/zoran/zoran_card.c
> +++ b/drivers/staging/media/zoran/zoran_card.c
> @@ -1038,9 +1038,9 @@ static int zr36057_init(struct zoran *zr)
>   	zr->stat_com = dma_alloc_coherent(&zr->pci_dev->dev,
>   					  BUZ_NUM_STAT_COM * sizeof(u32),
>   					  &zr->p_sc, GFP_KERNEL);
> -	if (!zr->stat_com) {
> +	if (!zr->stat_com)
>   		return -ENOMEM;
> -	}
> +
>   	for (j = 0; j < BUZ_NUM_STAT_COM; j++)
>   		zr->stat_com[j] = cpu_to_le32(1); /* mark as unavailable to zr36057 */
>   


Why does the subject line start with "media:" The subsystem is 
"staging:" so the subject should start with "staging: media: ..."

I have no clue if this is accepted.

Regards,

Philipp