Re: [PATCH 19/65] media: camss: Replace .open() file operation with v4l2_fh_open()
Vladimir Zapolskiy <[email protected]> Sun, 24 Aug 2025 22:04:45 +0300
| Newsgroups | gmane.linux.ports.tegra,gmane.linux.drivers.video-input-infrastructure,gmane.linux.kernel,gmane.linux.documentation,gmane.linux.ports.arm.kernel,gmane.linux.ports.arm.mediatek,gmane.linux.kernel.renesas-soc,gmane.linux.ports.arm.msm,gmane.linux.kernel.samsung-soc,gmane.linux.usb.general,gmane.linux.ports.arm.rockchip,gmane.comp.video.mjpeg.user |
|---|---|
| Message-ID | <[email protected]> |
Hi Jacopo, Laurent, thank you for the nice clean-up. On 8/2/25 12:22, Jacopo Mondi wrote: > From: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/[email protected]> > > The custom video_open() function in the camss driver open-codes the > v4l2_fh_open() helper, with an additional mutex that protects the whole > function. Given that the function does not modify any data guarded by > the lock, there's no need for using the mutex and the function can be > replaced by v4l2_fh_open(). > > Signed-off-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/[email protected]> > Signed-off-by: Jacopo Mondi <jacopo.mondi-ryLnwIuWjnjg/[email protected]> Tested-by: Vladimir Zapolskiy <[email protected]> Reviewed-by: Vladimir Zapolskiy <[email protected]> -- Best wishes, Vladimir