Re: [PATCH] Fix attribute parsing at SRT subtitles
Stefan Pöschel <[email protected]>
| Newsgroups | gmane.comp.video.mplayer.devel |
|---|---|
| Message-ID | <[email protected]> |
I just wanted to ask if there is any further information needed regarding the patch. Am 31.12.2015 um 14:37 schrieb Stefan Pöschel: > Hi, > > when SRT subtitles shall be displayed including formatting, they are > converted to ASS markup. The conversion therefore also processes the > "color" attribute of the HTML "font" tag. > > At the moment unfortunately also affects attributes who just have > "color" as a prefix, e.g. the attribute "back-color" which is sometimes > contained in subtitles. Therefore the value of this background color > attribute is by mistake used to set the text color. > > Please find attached a test SRT file (correct text color: white, not blue). > > The attached patch fixes this parsing by also including the leading > space when recognizing the "color" attribute and also the other attributes. > > Thanks and regards, > Stefan Pöschel > > > > _______________________________________________ > MPlayer-dev-eng mailing list > [email protected] > https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng > _______________________________________________ MPlayer-dev-eng mailing list [email protected] https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng