Re: [MPlayer-users] Build regression on FreeBSD
Alexander Strasser <[email protected]>
| Newsgroups | gmane.comp.video.mplayer.devel |
|---|---|
| Message-ID | <[email protected]> |
Am 30. Januar 2016 16:11:29 MEZ, schrieb "Ingo Brückl" <[email protected]>: >Alexander Strasser wrote on Fri, 29 Jan 2016 22:06:15 +0100: > >> What do you and others think about attached patch? > >Seems OK to me (untested though). > >> diff --git a/libmpcodecs/vd_ffmpeg.c b/libmpcodecs/vd_ffmpeg.c >> index 6a5885d..59752fe 100644 >> +++ b/libmpcodecs/vd_ffmpeg.c >> @@ -36,6 +36,7 @@ >> #include "fmt-conversion.h" >> >> #include "vd_internal.h" >> +#include "vdpau_frame_data.h" >> >> #if CONFIG_VDPAU >> #include "libavcodec/vdpau.h" > >I'd put the include into the '#if CONFIG_VDPAU' block just for reasons >of >clarity. > >> diff --git a/libmpcodecs/vdpau_frame_data.h >b/libmpcodecs/vdpau_frame_data.h >> new file mode 100644 > >> +#ifndef MPLAYER_VDPAU_FRAME_DATA_H >> +#define MPLAYER_VDPAU_FRAME_DATA_H >> + >> +#if CONFIG_VDPAU >> + >> +#include <vdpau/vdpau.h> > >If config definitions are being used, config.h should be included >first. Good catch! >Maybe it would be better to omit the #if and ensure it's only inlcude >in case >of VDPAU (which should be the case with my suggestion on vd_ffmpeg.c). Right. Don't know which is better... >Just my two cents. Thank you, Alexander _______________________________________________ MPlayer-dev-eng mailing list [email protected] https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng