Re: [PATCH v2] configure: Add support for OpenSSL

Hi all!

On 2016-02-21 21:18 +0100, Roberto Togni wrote:
> On Sat, 20 Feb 2016 15:18:48 +0200
> Lauri Kasanen <[email protected]> wrote:
> 
> > On Sat, 20 Feb 2016 11:30:44 +0100
> > Reimar Döffinger <[email protected]> wrote:
> > 
> > > I committed it, but afterwards I was thinking (but have not tested):
> > > Does it need to disable gnutls?
> > > Because if gnutls is installed and you use this option,
> > > it will enable both and I'm not sure that will work
> > > as expected (if it compiles at all).
> > > Not a big deal but would be nice to check if you
> > > have time.
> > 
> > Thanks.
> > 
> > My systems do not have gnutls, so I'd need to spin up a VM, which may
> > take a bit.
> >

> I can confirm that it compiles correctly with both gnutls and
> openssl (tested on Debian stable).

  I too can confirm that it builds.

> No idea if it works correctly.

  Seems to work as well. At least with a quick test I did not
notice any problems.

  Because I was curious I investigated the situation a bit more.
My analysis so far:

  1) Both tls protocol implementations will be built and linked
  2) It chooses gnutls
  3) I guess that is because it is registered before openssl
     and because the search happens to start from the start of
     the list of registered protocols.
  4) no errors happen even/because both protocols are named the same: "tls"
  5) global init functions for both libraries (gnutls,openssl) will be
     called

That is all I could find out so far. In FFmpeg's configure I think
it cannot happen that 2 tls implementations are activated, though
I did not test and the section declaring the deps was not very
easy to read and I am no expert for FFmpeg configure's dep system.

  So IMHO considering that the openssl support must be explicitly
activated and both libs must be present (including headers) and
there are no obvious downsides known, there is no need to rush
a solutions here.

  Alexander

_______________________________________________
MPlayer-dev-eng mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlbLhKkACgkQp9ile6h25Y+ijQCgmXLJVb2kUDEtVJo+b5R5k4xY
jHcAnRBVNcX759EVZg02BGuv+NpZQz9H
=Bq51
-----END PGP SIGNATURE-----