Re: [MPlayer-cvslog] r37801 - trunk/etc/codecs.conf

On 2016-07-21 23:04 +0200, Alexander Strasser wrote:
> The quoted commit below introduced a crash, with I guess
> paletted gif at least on Windows.

Sorry I forgot to mention here: this was reported as ticket #2301 


> Would it be worth to revert the commit for now, to mitigate
> the problem?
> 
> My analysis so far:
> Right before the crash at line 479 in libmpcodecs/vd_ffmpeg.c
> the condition at line 475 will strangely evaluate to false, and
> the  negative value of sh->bih->biSize will lead to a failed
> allocation a few lines below; which in turn triggers the crash
> inside memcpy at line 479.
> 
> 
>   Alexander
> 
> 
> On 2016-02-25 22:34 +0100, reimar wrote:
> > Author: reimar
> > Date: Thu Feb 25 22:34:45 2016
> > New Revision: 37801
> > 
> > Log:
> > codecs.conf: Prefer FFmpeg raw decoder for paletted.
> > 
> > It is more likely to give the correct results,
> > it seems even when combined with our native e.g.
> > AVI demuxer, and it has more feature like supporting
> > paletted 1-bit formats.
> > 
> > Modified:
> >    trunk/etc/codecs.conf
> > 
> > Modified: trunk/etc/codecs.conf
> > ==============================================================================
> > --- trunk/etc/codecs.conf	Thu Feb 25 22:34:43 2016	(r37800)
> > +++ trunk/etc/codecs.conf	Thu Feb 25 22:34:45 2016	(r37801)
> > @@ -4258,6 +4258,20 @@ videocodec rawbgr15
> >    format 0x4247520F
> >    out BGR15
> >  
> > +videocodec ffrawpal
> > +  info "RAW PAL8"
> > +  comment "For decoding paletted 1, 2, 4 and 8 bit formats"
> > +  status working
> > +  driver ffmpeg
> > +  dll rawvideo
> > +  format 0x0
> > +  format 0x20776172 0x42475208
> > +  format 0x42475208
> > +  format 0x42475204
> > +  format 0x42475202
> > +  format 0x42475201
> > +  out BGR8,BGR1,RGB1
> > +
> >  videocodec rawbgr8
> >    info "RAW BGR8"
> >    status working
> > @@ -4276,18 +4290,6 @@ videocodec rawbgr1
> >    format 0x42475201
> >    out BGR1
> >  
> > -videocodec ffrawpal
> > -  info "RAW PAL8"
> > -  comment "For decoding paletted 2 and 4 bit formats"
> > -  status working
> > -  driver ffmpeg
> > -  dll rawvideo
> > -  format 0x0
> > -  format 0x20776172 0x42475204
> > -  format 0x42475204
> > -  format 0x42475202
> > -  out BGR8
> > -
> >  videocodec rawyuy2
> >    info "RAW YUY2"
> >    status working

_______________________________________________
MPlayer-dev-eng mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAleRPfAACgkQp9ile6h25Y8NMQCfbwC4SvV/BLAbLXLpcY5nRI/8
ZOYAn3JdO2TvPg1Be0Nc1R5AkHARG/+V
=xiwu
-----END PGP SIGNATURE-----