Re: [PATCH] Determine replay gain
Ingo Brückl <[email protected]>
| Newsgroups | gmane.comp.video.mplayer.devel |
|---|---|
| Message-ID | <[email protected]> |
Reimar Döffinger wrote on Sun, 2 Apr 2017 17:41:02 +0200: > On Fri, Mar 31, 2017 at 04:17:45AM +0200, Ingo Brückl wrote: >> >> +static int r_gain; > Shouldn't use global variables except for options (and even that > is not a very good idea). Yes, I know, but unfortunately mp3_vbr_frames() which determines the replay gain doesn't have access to anything but stream_t *s. I wanted to avoid changing its parameter list, but if it's okay to pass da_priv_t *, I'll do. Ingo _______________________________________________ MPlayer-dev-eng mailing list [email protected] https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng