Re: [PATCH 2/5] vo_xv: When copying planes use the associated pitch

On 6/23/17, Ivan Kalvachev <[email protected]> wrote:
> On 6/15/17, Alexander Strasser <[email protected]> wrote:
>> This probably never mattered as the chroma planes probably always
>> had used the same pitch value in there layouts.
>>
>> Signed-off-by: Alexander Strasser <[email protected]>
>> ---
>>  libvo/vo_xv.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libvo/vo_xv.c b/libvo/vo_xv.c
>> index a39c8d504..783e91d84 100644
>> --- a/libvo/vo_xv.c
>> +++ b/libvo/vo_xv.c
>> @@ -409,7 +409,7 @@ static int draw_slice(uint8_t * image[], int
>> stride[],
>> int w, int h,
>>
>>      dst = xvimage[current_buf]->data + xvimage[current_buf]->offsets[2]
>> +
>>          xvimage[current_buf]->pitches[2] * y + x;
>> -        memcpy_pic(dst, image[idx_p2], w, h,
>> xvimage[current_buf]->pitches[1],
>> +        memcpy_pic(dst, image[idx_p2], w, h,
>> xvimage[current_buf]->pitches[2],
>
> Are you sure this shouldn't be "pitches[idx_p2]" ?
Sorry, Ignore what I said.

It is using offsets[2] and it matches with pitches[2].

Your patch is correct.
_______________________________________________
MPlayer-dev-eng mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng