Re: [PATCH] Allow user to choose strip program when configure

Hi Hank,

thanks for sending the patch! Looks OK to me.

I guess it won't work with BSD versions of install. If I understand
correctly, you would need to have an environment variable named
STRIPBIN set up with the path of the strip program to use and
they don't have a command line option for changing the used strip
program.

AFAIK the program install isn't standardized at all, so I don't know
if there are even more variations, besides GNU and BSD to consider.

I think it's not that important to have it working everywhere right
now, because I can't see that suddenly lots of MPlayer builders would
use that option. Though after writing this, I wonder how others
cross-compiling MPlayer currently deal with the situation or they
all just don't strip the binaries at all? Or they do it manually
before or after install?

I will give it a bit more thought and commit your patch if I can't
find anymore problems. If other have comments now would be the right
time.


Best regards,
  Alexander

On 2020-02-08 09:21 +0000, [email protected] wrote:
> My mistake, resend the patch.
>
> --- ./configure2020-02-08 16:33:21.994541380 +0800
> +++ ./configure_new2020-02-08 16:36:00.130548921 +0800
> @@ -554,6 +554,7 @@
>    --enable-runtime-cpudetection    enable runtime CPU detection [disable]
>    --enable-cross-compile enable cross-compilation [autodetect]
>    --cc=COMPILER          C compiler to build MPlayer [gcc]
> +  --strip=STRIP          strip program to strip MPlayer when install [strip]
>    --host-cc=COMPILER     C compiler for tools needed while building [gcc]
>    --as=ASSEMBLER         assembler to build MPlayer [as]
>    --nm=NM                nm tool to build MPlayer [nm]
> @@ -659,6 +660,7 @@
>  _ranlib=ranlib
>  _windres=windres
>  _cc=cc
> +_strip=strip
>  _ar=ar
>  _arflags=rc
>  # create thin archive to save disk space and I/O
> @@ -958,6 +960,9 @@
>    --cc=*)
>      _cc=$(option_value $ac_option)
>      ;;
> +  --strip=*)
> +    _strip=$(option_value $ac_option)
> +    ;;
>    --host-cc=*)
>      _host_cc=$(option_value $ac_option)
>      ;;
> @@ -2847,7 +2852,7 @@
>
>
>  # Checking for CFLAGS
> -_install_strip="-s"
> +_install_strip="-s --strip-program=$_strip"
>  if test -z "$CFLAGS" || test "$_profile" != "" || test "$_debug" != ""; then
>    if test "$cc_vendor" = "intel" ; then
>      CFLAGS="-O2 $_march $_mcpu $_pipe -fomit-frame-pointer"
> @@ -8726,7 +8731,7 @@
>  YASMFLAGS  = $YASMFLAGS
>  X86ASMFLAGS = $YASMFLAGS -o\$@
>  DEPX86ASMFLAGS=\$(X86ASMFLAGS)
> -STRIP      = strip
> +STRIP      = $_strip
>
>  CONFIG_FFPROBE       = no
>  CONFIG_LAVFI_INDEV   = no
>
>
> Best Regards,
> Hank Wang
>
> ________________________________________
> 寄件者: MPlayer-dev-eng <[email protected]> 代表 [email protected] <[email protected]>
> 寄件日期: 2020年02月08日 17:07
> 收件者: [email protected]
> 主旨: [MPlayer-dev-eng] [PATCH] Allow user to choose strip program when   build
>
> Hi all!
>
> Here is a small patch to update configure for choosing the right strip program when make install in cross compile situation.
> Any comments are welcome, thanks !
>
> Best Regards,
> Hank Wang
[...]
_______________________________________________
MPlayer-dev-eng mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng