Re: [PATCH] Allow user to choose strip program when configure

On 8 February 2020 10:21:23 CET, [email protected] wrote:
>My mistake, resend the patch.

My suggestion would be to default to empty for strip, and only append
--strip-program if it's non-empty.
That would adress both compatibility concerns and "install" variants clever enough to figure out the right strip command. 
That said, I am a bit surprised, I thought the "strip" command could usually handle all ELF files, independent of architecture?
Also, isn't it a bit unusual to run "make install" when cross-compiling?
That said except for the compatibility concerns I'm not against this change. 

Best regards, 
Reimar

>
>--- ./configure2020-02-08 16:33:21.994541380 +0800
>+++ ./configure_new2020-02-08 16:36:00.130548921 +0800
>@@ -554,6 +554,7 @@
>--enable-runtime-cpudetection    enable runtime CPU detection [disable]
>   --enable-cross-compile enable cross-compilation [autodetect]
>   --cc=COMPILER          C compiler to build MPlayer [gcc]
>+  --strip=STRIP          strip program to strip MPlayer when install
>[strip]
>--host-cc=COMPILER     C compiler for tools needed while building [gcc]
>   --as=ASSEMBLER         assembler to build MPlayer [as]
>   --nm=NM                nm tool to build MPlayer [nm]
>@@ -659,6 +660,7 @@
> _ranlib=ranlib
> _windres=windres
> _cc=cc
>+_strip=strip
> _ar=ar
> _arflags=rc
> # create thin archive to save disk space and I/O
>@@ -958,6 +960,9 @@
>   --cc=*)
>     _cc=$(option_value $ac_option)
>     ;;
>+  --strip=*)
>+    _strip=$(option_value $ac_option)
>+    ;;
>   --host-cc=*)
>     _host_cc=$(option_value $ac_option)
>     ;;
>@@ -2847,7 +2852,7 @@
>
>
> # Checking for CFLAGS
>-_install_strip="-s"
>+_install_strip="-s --strip-program=$_strip"
>if test -z "$CFLAGS" || test "$_profile" != "" || test "$_debug" != "";
>then
>   if test "$cc_vendor" = "intel" ; then
>     CFLAGS="-O2 $_march $_mcpu $_pipe -fomit-frame-pointer"
>@@ -8726,7 +8731,7 @@
> YASMFLAGS  = $YASMFLAGS
> X86ASMFLAGS = $YASMFLAGS -o\$@
> DEPX86ASMFLAGS=\$(X86ASMFLAGS)
>-STRIP      = strip
>+STRIP      = $_strip
>
> CONFIG_FFPROBE       = no
> CONFIG_LAVFI_INDEV   = no
>
>
>Best Regards,
>Hank Wang
>
>________________________________________
>寄件者: MPlayer-dev-eng <[email protected]> 代表
>[email protected] <[email protected]>
>寄件日期: 2020年02月08日 17:07
>收件者: [email protected]
>主旨: [MPlayer-dev-eng] [PATCH] Allow user to choose strip program when  
>build
>
>Hi all!
>
>Here is a small patch to update configure for choosing the right strip
>program when make install in cross compile situation.
>Any comments are welcome, thanks !
>
>Best Regards,
>Hank Wang
>
>
>--
>本信件可能包含工研院機密資訊，非指定之收件者，請勿使用或揭露本信件內容，並請銷毀此信件。 This email may contain
>confidential information. Please do not use or disclose it in any way
>and delete it if you are not the intended recipient.
>
>
>--
>本信件可能包含工研院機密資訊，非指定之收件者，請勿使用或揭露本信件內容，並請銷毀此信件。 This email may contain
>confidential information. Please do not use or disclose it in any way
>and delete it if you are not the intended recipient.

_______________________________________________
MPlayer-dev-eng mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng