Re: [PATCH] Remove unnecessary/duplicated includes.

Hi,

On 23.01.21 18:32, Reimar Döffinger wrote:
> In particular sys/time.h is included in a lot
> of places that do not need or need it only
> when specific defines are set.
> Besides being cleaner this should also be
> better for portability, though there is a
> risk of it breaking something on some
> less common systems.

Just in case I'll build-test the patch on Ubuntu GNU/Linux.

> ---
>   input/input.c             |  2 ++
>   libao2/ao_alsa.c          |  1 -
>   libmenu/menu_console.c    | 14 ++++++++++----
>   libmpcodecs/vf_filmdint.c |  6 ++----
>   mencoder.c                |  1 -
>   mplayer.c                 |  3 ---
>   stream/freesdp/common.h   |  1 -
>   stream/frequencies.c      |  1 -
>   stream/librtsp/rtsp.c     |  2 +-
>   stream/network.h          |  2 +-
>   stream/pnm.c              |  2 +-
>   stream/stream_dvb.c       |  1 -
>   stream/stream_pvr.c       |  1 -
>   stream/tcp.c              |  2 +-
>   stream/tv.c               |  1 -
>   stream/udp.c              |  2 +-
>   16 files changed, 19 insertions(+), 23 deletions(-)

The patch does not apply completely with GNU patch 2.7.6 and default
"fuzz" setting to a fresh Subversion checkout:

...
checking file mencoder.c
Hunk #1 FAILED at 50.
1 out of 1 hunk FAILED
...

It does when setting maximum "fuzz" to 3 with "-F3".

The patched sources compile on my system, and the resulting
mplayer binary could successfully play a video and an audio
file that had worked with the unpatched binary. :-)

Thanks,
Erik
_______________________________________________
MPlayer-dev-eng mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng