Re: [PATCH] fix broken build since r38235

Hi,

On 23.01.21 23:28, Reimar Döffinger wrote:
>> On 23 Jan 2021, at 21:16, Erik Auerswald <[email protected]> wrote:
>> On 23.01.21 19:52, Erik Auerswald wrote:
>>> On 23.01.21 19:22, reimar wrote:
>>>> Author: reimar
>>>> Date: Sat Jan 23 20:22:15 2021
>>>> New Revision: 38235
>>> After the recent changes, MPlayer no longer compiles for me.
>>> since the problem occurs in the file libmpcodecs/vf_spp.c
>>> I assume that this check in to be the cause.
>>>> Log:
>>>> Switch to using DECLARE_ALIGNED for better portability.
>>
>> Using DECLARE_ALIGNED instead of LOCAL_ALIGNED_16 fixes the
>> compilation error for me, please see attached patch.  I hope
>> that I've used DECLARE_ALIGNED correctly.
> 
> Using DECLARE_ALIGNED is not correct to use for stack variables.

Thanks, I did not know that (and did not investigate, my fault).

> I guess I must have had some interaction with one of my other
> patches in testing so I didn’t see the failure.
> I hope it’s fixed now with the missing include added.

Yes, the code compiles again and MPlayer works at least for the two
files I tested. :-)

> Thanks for testing my stuff, much appreciated!

Your welcome.  Thanks for working on MPlayer!

Best regards,
Erik
_______________________________________________
MPlayer-dev-eng mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng