Re: [PATCH] Fix compilation against latest FFmpeg.

On 2021-05-01 17:29 +0200, Reimar Döffinger wrote:
> On Sat, May 01, 2021 at 03:34:49PM +0200, Alexander Strasser wrote:
> > On 2021-05-01 13:04 +0200, Alexander Strasser wrote:
> > >
> > > Others are worrying because previously differently decoded frames become
> > > all the same, like in this example:
> >
> > Unsure at what cost, but simply removing this
> >
> >     av_dict_set(&opts, "fflags", "+keepside", 0);
> >
> > line in libmpdemux/demux_lavf.c at L608 makes the tests happy again.
>
> I think didn't do anything ever since we added the explicit
> side data merging in 2016?
> Is that the only issue? Should I apply my patch, with that
> change on top then?

Yeah, that would be great.


> Can disable mencoder by default, or see it it's possible to fix
> soonish after that.
> Btw. vf_screenshot would also be good to test, I admit I did not.

Tested vo png and vf screenshot. Both seem to work fine. I didn't
test many variations, but IMHO that shouldn't be blocker given
the current situation with a broken build.

Maybe you can just disable mencoder build by default for now as a
short term measure.


  Alexander