Re: [PATCH 1/2] libmpdemux/mf: Replace sprintf by mp_asprintf
Alexander Strasser <[email protected]> Tue, 1 Jun 2021 22:20:13 +0200
| Newsgroups | gmane.comp.video.mplayer.devel |
|---|---|
| Message-ID | <[email protected]> |
On 2021-05-12 21:42 +0200, Alexander Strasser wrote: > On 2021-04-29 18:43 +0200, Alexander Strasser wrote: > > On 2021-04-28 21:09 +0200, Reimar Döffinger wrote: > > > > > > A new variable local to this block would make it much easier to argue memory correctness. > > > This probably also applies to the other usages of this “fname” variable, > > > but that’s a somewhat separate issue. > > > [...] > > > > If you want to review it, I could try to refactor the > > individual ways to gather the file lists into individual > > functions. Localizing variables to those functions as > > much as possible. > > Patch attached. Only lightly tested. First wanted to know > if you like it. Improved version resubmitted in the new patch set. Alexander _______________________________________________ MPlayer-dev-eng mailing list [email protected] https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng