Re: [PATCH] Have sndio check use the pkg-config file

On 2/27/2022 3:58 AM, Reimar Döffinger wrote:
>
>> On 26 Feb 2022, at 22:49, Brad Smith <[email protected]> wrote:
>>
>> Have the sndio check use the pkg-config file.
>>
>> BTW, looking at other examples to take inspiration for this I noticed the Pulse
>> and JACK bits use libs_mplayer vs extra_ldflags and echores is higher up. Little
>> inconsistencies are kind of annoying when looking at code to get an idea of how
>> to do things.
> Using extra_ldflags means mencoder will also link against it, which I suspect is not correct here?
Actually testing this out I see why. Yes, this is correct here.
> I think it might also cause issues with static linking.
> So yes it would be better to change that.
> Also why did you change from statement_check to header_check?

I was copying what Pulse was doing, not being sure what was appropriate. 
Pulse has a library so it should
be checking that as well I would think.

> That is not right since it will not test linking (and thus --libs for pkg_config makes no sense).
> I am not familiar with sndio, is there a significant chance people might be using it without pkg-config file installed?
>
> _______________________________________________
> MPlayer-dev-eng mailing list
> [email protected]
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
_______________________________________________
MPlayer-dev-eng mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng