Re: [PATCH] Remove OpenBSD bits from Sun audio backend

Alexandre Ratchov <[email protected]> Sun, 20 Mar 2022 02:03:47 +0100

Newsgroups	gmane.comp.video.mplayer.devel
Message-ID	<[email protected]>

On Sat, Mar 19, 2022 at 09:45:33PM +0100, Reimar Döffinger wrote:
> Hi!
> 
> > On 18 Mar 2022, at 20:57, Brad Smith <[email protected]> wrote:
> > 
> > ping.
> > 
> > On 3/2/2022 8:18 PM, Brad Smith wrote:
> >> Remove some OpenBSD bits from the Sun audio backend. We have been using sndio
> >> for 12+ years.
>  We were wondering just out of principle, is that just because the
> code is outdated/unnecessary, or because ao_sun can not work on
> OpenBSD at all anymore?

Hi,

The SunAudio-style ioctls and associated structures don't exist
anymore, so the code doesn't build on OpenBSD.

> In the latter case it would be a bit the question, what's the harm
> in leaving it in as-is...

I see no harm: ao_sun.c is not used on OpenBSD, and __OpenBSD__ is not
defined on OSes using ao_sun.c.