Re: Brightness broken

Hi Nicolas!
> On 15 May 2022, at 21:14, Nicolas George <[email protected]> wrote:
> I have videos for which FFmpeg commit 5f3a160b42 broke setting the
> brightness (using vo_gl).
> 
> Steps to reproduce:
> 
> - Create a test video:
> 
>  ffmpeg -lavfi testsrc2=s=1280x720:d=2 -c:v libx265 \
>    -pix_fmt yuv420p10 -crf 18 -y /tmp/test.mkv
> 
> - Build mplayer.
> 
> - Run mplayer on the test video with exaggerated brightness:
> 
>  ./mplayer -brightness 80 /tmp/test.mkv
> 
> - Change libswscale/utils.c:1039 to "return -1" (lightweight revert
>  5f3a160b42), build and re-test.

Unfortunately I can't reproduce.
This change makes no difference, in all cases, the behaviour is:
- brightness works with -vo gl
- works but looks different with -vo gl:yuv=0
- does not work with -vo corevideo

I guess it could be specific to Linux/graphics driver/support texture formats?

Best regards,
Reimar