Re: [PATCH] Fix incorrect API usage for FFmpeg

Reimar Döffinger <[email protected]> Fri, 3 Feb 2023 21:23:51 +0100

Newsgroups	gmane.comp.video.mplayer.devel
Message-ID	<[email protected]>


> On 24 Jan 2023, at 18:45, Brad Smith <[email protected]> wrote:
> 
> ping.
> 
> On 1/12/2023 10:54 AM, Brad Smith wrote:
>> Building with Clang 15 it has kicked up an error exposing what appears
>> to be incorrect API usage for FFmpeg.
>> 
>> 
>> libmpcodecs/ve_lavc.c:444:39: error: incompatible integer to pointer conversion assigning to 'RcOverride *' (aka 'struct RcOverride *') from 'int' [-Wint-conversion]
>>         lavc_venc_context->rc_override=
>>                                       ^

Sorry for the delay, it should be fixed now.
Differently though, I think the reallocp variant
is the right one to use, just needs to be used correctly.