Re: [PATCH] Fix a sndio crash when exiting in muted state

On 2023-03-24 4:38 p.m., Alexander Strasser wrote:
> Hi Brad,
>
> On 2023-03-22 22:58 +0100, Reimar Döffinger wrote:
>>> Index: libao2/ao_sndio.c
>>> ===================================================================
>>> --- libao2/ao_sndio.c (revision 38412)
>>> +++ libao2/ao_sndio.c (working copy)
>>> @@ -159,6 +159,7 @@
>>>      pfds = NULL;
>>>      sio_close(hdl);
>>>      hdl = NULL;
>>> +    havevol = 0;
>>>      return 0;
>>> }
>>>
>>> @@ -172,6 +173,7 @@
>>>      hdl = NULL;
>>>      free(pfds);
>>>      pfds = NULL;
>>> +    havevol = 0;
>>> }
>> Well, it's probably a good idea to do that, but a aoctl happening after uninit (if I understand right) is the far worse issue an probably needs to be fixed by itself.
>
> Could you test if the attached patch also fixes the issues you observed?
>
> Only lightly tested but it would help if you could confirm if it fixes
> the problem.
>
>
> Thanks,
>    Alexander

According to feedback MPlayer no longer crashes with this applied and 
the other patch
removed.
_______________________________________________
MPlayer-dev-eng mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng