Re: [PATCH] Fix a sndio crash when exiting in muted state

On 2023-03-28 21:25 +0200, Alexander Strasser wrote:
> On 2023-03-26 15:58 +0200, Reimar Döffinger wrote:
> >
> > > On 25 Mar 2023, at 16:22, Reimar Döffinger <[email protected]> wrote:
> > >
> > >> On 24 Mar 2023, at 21:38, Alexander Strasser <[email protected]> wrote:

[patches snipped]

> > After some discussion, probably all our patches make sense, but a full solution likely needs a bit more.
> > Essentially, I think the aos need to have a flag whether their mixer (volume etc) is a global, persistent one.
> > If it is, we should not NULL the mixer audio out here, but instead require the ao SETVOLUME remains valid/allowed after uninit.
> > To do it really properly, there would be also some additional logic to handle it fully correctly when different files are played with different -ao options.
>
> I would like doing something like that after a release.
>
> Would need some design and probably more or less changes in all aos
> depending on the exact architecture chosen.
>
>
> > Each of the patches on their own fixes that specific crash, and mine is probably safest there, but without Alexander's causes a regression (audio remains muted after MPlayer exits).
> > So if no objections, I think it would be best for someone (Alex?) to apply them all in one go.
>
> I intent to apply all of the patches after a quick test session in one go.
>
> Will do it probably on Friday.

All patches committed.

Sorry for the week long delay.
I did bit more testing and tried to make the commit messages
more exhaustive.


Best regards,
  Alexander