Re: [RFC][PATCH 0/8] Adjustments for current FFmpeg git including major bumps

Hi Ingo!


On 2024-04-04 19:01 +0200, Ingo Brückl wrote:
> On Thu, 4 Apr 2024 00:38:27 +0200, Alexander Strasser wrote:
>
> > As always comments and testing very welcome!
>
> Here you go:

Thanks for testing and your quick feedback!


> (1) With current ffmpeg checkout, compiled and linked as shared libraries
>     (--enable-gui --disable-ffmpeg_a) - something that has always worked -
>     I am missing some audio output now, for example:
>
>   Trying to force audio codec driver family hwac3...
>   Requested audio codec family [mpg123] (afm=mpg123) not available.
>   Enable it at compilation.
>   Opening audio decoder: [ffmpeg] FFmpeg/libavcodec audio decoders
>   AUDIO: 44100 Hz, 2 ch, floatle, 96.0 kbit/3.40% (ratio: 12000->352800)
>   Selected audio codec: [ffmp2float] afm: ffmpeg (FFmpeg MPEG layer-1 and layer-2 audio)
>   ==========================================================================
>   AO: [alsa] 48000Hz 2ch floatle (4 bytes per sample)
>   [SWR @ 0xb6cdc080]Input channel layout "" is invalid or unsupported.
>   [libaf] Reinitialization did not work, audio filter 'lavcresample' returned error code -2
>   Couldn't find matching filter/ao format!
>   Audio: no sound
>
> or
>
>   Trying to force audio codec driver family hwac3...
>   Opening audio decoder: [ffmpeg] FFmpeg/libavcodec audio decoders
>   [eac3 @ 0xb6022600]Too many channels: 1551
>   Could not open codec.
>   ADecoder init failed :(
>   ADecoder init failed :(
>   Opening audio decoder: [spdif] libavformat/spdifenc audio pass-through decoder.
>   [spdif @ 0xb6c078c0]spdif muxer does not support any stream of type unknown
>   ADecoder init failed :(
>   ADecoder init failed :(
>   Cannot find codec for audio format 0x33434145.
>   Audio: no sound

That definitely smells like it is related to the AVChannelLayout
changes.

For the few samples I tested. Audio worked. Will have to dig deeper...


> (2) With current ffmpeg checkout, statically linked with MPlayer
>     (--enable-gui --enable-ffmpeg_a) I get errors while compiling:
>
>   libavformat/dvdvideodec.c:35:10: fatal error: dvdnav/dvdnav.h: No such file or directory
>
> even though
>
>   #undef CONFIG_DVDNAV
>   #undef CONFIG_DVDREAD

The build failures are probably due to dvd demuxer that was recently
added to FFmpeg (commit a1304272c3a0ef7c3d77c7).

Could you change MPlayer configure like this

```
--- a/configure
+++ b/configure
@@ -1663,7 +1663,7 @@ libavfilters=$(echo $libavfilters_all)
 libavdecoders=$(filter_out_component decoder 'LIB[A-Z0-9_]* [A-Z0-9]*_QSV [A-Z0-9]*_MMAL [A-Z0-9]*_MEDIACODEC [A-Z0-9]*_CUVID [A-Z0-9_]*_AT [A-Z0-9]*_RKMPP [A-Z0-9]*_V4L2M2M')
 libavencoders=$(filter_out_component encoder 'LIB[A-Z0-9_]* [A-Z0-9]*_QSV [A-Z0-9]*_MMAL [A-Z0-9]*_MEDIACODEC NVENC[A-Z0-9_]* AV1_NVENC[A-Z0-9_]* H264_NVENC[A-Z0-9_]* HEVC_NVENC[A-Z0-9_]* HAP [A-Z0-9]*_VIDEOTOOLBOX [A-Z0-9]*_VAAPI [A-Z0-9]*_OMX [A-Z0-9_]*_AT [A-Z0-9]*_V4L2M2M [A-Z0-9]*_AMF [A-Z0-9]*_MF')
 libavbsfs=$(filter_out_component bsf 'TRACE_HEADERS [A-Z0-9_]*_METADATA H264_REDUNDANT_PPS FILTER_UNITS')
-libavdemuxers=$(filter_out_component demuxer 'AVISYNTH LIB[A-Z0-9_]* REDIR VAPOURSYNTH')
+libavdemuxers=$(filter_out_component demuxer 'AVISYNTH LIB[A-Z0-9_]* REDIR VAPOURSYNTH DVDVIDEO')
 libavmuxers=$(filter_out_component muxer 'CHROMAPRINT LIB[A-Z0-9_]* RTP RTSP SAP')
 libavprotocols=$(filter_out_component protocol 'BLURAY FFRTMPCRYPT HTTPS LIB[A-Z0-9_]* TLS TLS_GNUTLS TLS_OPENSSL TLS_SECURETRANSPORT TLS_SCHANNEL ANDROID_CONTENT')
 libavfilters=$(filter_out_component filter 'VF_FREI0R[A-Z0-9_]* LIB[A-Z0-9_]* MP VF_OCV')
```

and try a fresh build?


  Alexander

> in my config.h. Trying to use my dvdnav/dvdread v6.0.0 include files
> (probably too old) leads to further errors:
>
>   libavformat/dvdvideodec.c:174:51: error: unknown type name 'dvd_logger_level_t'
>   libavformat/dvdvideodec.c:191:50: error: unknown type name 'dvdnav_logger_level_t'
>   libavformat/dvdvideodec.c: In function 'dvdvideo_ifo_open':
>   libavformat/dvdvideodec.c:227:5: error: unknown type name 'dvd_logger_cb'
>
> Ingo