Re: Let af_lavcresample use float point sample format.

--===============3390067188491012599==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="IJpNTDwzlM2Ie8A6"
Content-Disposition: inline


--IJpNTDwzlM2Ie8A6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi

On Sat, Apr 20, 2024 at 01:04:00AM +0200, Alexander Strasser wrote:
> Hi Ivan,
>=20
> On 2024-04-15 21:40 +0300, Ivan Kalvachev wrote:
> > While fixing ch_layout in af_lavcresample, I've noticed that libaf
> > inserts two format change filters - one before lavcresample to do
> > float->s16le and one after to do s16le->float. Since swresample
> > handles float point sample format natively, it should be both faster
> > and better quality to use it.
> >
> > If float point sample format is requested by libaf at initialization,
> > use swresample float point sample format for the conversion.
> > Adjust internal buffer size calculations to use a variable (bps).
> > Store the used format in the filter context structure to avoid
> > unnecessary reinitialization.
>=20
> Cannot comment much on the inter workings of libaf and libswr, but
> the code looks good to me.

I cant comment on libaf either but if it works it should be correct
its quite unlikely to be wrong and working

thx

[...]

--=20
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data

--IJpNTDwzlM2Ie8A6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZiMIqgAKCRBhHseHBAsP
q7oSAJ9tm9ncgFdAxIc7WrvNXGfRVAD9gwCeKjHnEiGGLWoiWKPpfvEBdP/6jFQ=
=9JUo
-----END PGP SIGNATURE-----

--IJpNTDwzlM2Ie8A6--

--===============3390067188491012599==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
MPlayer-dev-eng mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

--===============3390067188491012599==--