Re: Unbreak build
Nicolas George <[email protected]> Sat, 21 Sep 2024 11:37:30 +0200
| Newsgroups | gmane.comp.video.mplayer.devel |
|---|---|
| Message-ID | <[email protected]> |
Alexander Strasser (12024-09-20): > Hi Nicolas! Hi. Thanks for reviewing. > I have sent a similar big patch before on this list also linked from > this ticket: https://trac.mplayerhq.hu/ticket/2424 Oh, it is already old. > You could compare a little against my version and apply yours. Mine > has too many changes because I accidentally also worked on instances > that were still only warnings in GCC-14. Fixing warnings is a good investment. > Actually I think that many of the changes are not really for the > better, but the problem is within FFmpeg APIs for most of them. The core issue is in the typing system of the C language: it cannot express const in a satisfactory way. > I also considered using -fno-math-errno and -fno-trapping-math instead. > But after reading GCC BUG 88576 > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88576) I feel like maybe > better not to and just play it safe. I agree. > Thanks for your work on this! Feel free to go ahead and commit to SVN. Just did so. And did not get mplayer-cvslog mails, I need to check that. Regards, -- Nicolas George